Skip to content

Commit 3a596b5

Browse files
Update PreFast run stage in OneBranchBuild.yml to "Guardian" to avoid race condition with build. (#1534)
* Remove PreFast settings from OneBranch pipeline Removed PreFast parameters from build configuration. * Update PreFast run stage in OneBranchBuild.yml Changed PreFast run stage from 'Build' to 'Guardian' to enable it only during the Guardian stage. * Correct indentation for PreFast configuration Fix indentation for ob_sdl_prefast_runDuring in OneBranchBuild.yml
1 parent a7a5cd9 commit 3a596b5

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

.pipelines/OneBranch.Official.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ extends:
5757
BuildConfiguration: $(BuildConfiguration)
5858
BuildVersion: $(BuildVersion)
5959
OfficialBuild: true
60-
ob_sdl_prefast_enabled: true
61-
ob_sdl_prefast_runDuring: "Guardian" # Enabling PreFast only for build stage
6260

6361
- stage: vpack
6462
dependsOn: build
@@ -68,7 +66,6 @@ extends:
6866
type: windows
6967
variables:
7068
ob_outputDirectory: '$(Build.SourcesDirectory)\out'
71-
7269
ob_createvpack_enabled: true
7370
ob_createvpack_packagename: CppWinRT.Compiler
7471
ob_createvpack_owneralias: cpp4uwpt

.pipelines/jobs/OneBranchBuild.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
ob_sdl_codeSignValidation_excludes: '-|**\*.exe;-|**\*.dll'
3333

3434
ob_sdl_prefast_enabled: true
35-
ob_sdl_prefast_runDuring: 'Build'
35+
ob_sdl_prefast_runDuring: "Guardian"
3636
ob_sdl_checkCompliantCompilerWarnings: true
3737

3838
ob_symbolsPublishing_enabled: ${{ parameters.OfficialBuild }}

0 commit comments

Comments
 (0)