compile_commands.json should not contain unresolved variables

[lukka]

When generating compile_commands.json for the Terminal repository (OpenConsole.slnx), some entries contain unresolved MSBuild variables such as $(OpenConsoleDir).

Example:

{
  "file": ".../src/cascadia/UnitTests_TerminalCore/ScreenSizeLimitsTest.cpp",
  "arguments": [
    "...",
    "/I[REDACTED]\\src\\cascadia\\UnitTests_TerminalCore\\\"$(OpenConsoleDir)\\src\\cascadia\\TerminalControl\\Generated Files\\\""
  ]
}

compile_commands.json is expected to contain concrete, fully resolved command lines (command or arguments with directory and file). Tools that consume this database generally expect paths and flags to be fully expanded, so unresolved tokens can break or degrade tooling behavior.

[gcampbell-msft]

@lukka Do you have an explicit repro? When I did a simple repro on the Terminal repository, I don't see the $(OpenConsoleDir). However, I do see things like $(GeneratedFilesDir), which I'm investigating. However, it'd be good to have a consistent repro for the issue you're seeing 👍

[lukka]

@gcampbell-msft Thanks! I can test it out myself on my environment. I've got both $(OpenConsoleDir) and $(GeneratedFilesDir).

[gcampbell-msft]

Fixed by #8