From 7ebfdf6f43d48916a336c16ea43188f82841b5ae Mon Sep 17 00:00:00 2001 From: Mikhail Date: Thu, 29 May 2025 18:18:42 +0200 Subject: [PATCH] Add pr template --- .github/PULL_REQUEST_TEMPLATE.md | 118 +++++++++++++++++++++++++++++++ 1 file changed, 118 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..e509260 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,118 @@ + + + +## Assignment: [COURSE_CODE] - Assignment [X]: [Assignment Title] + + + +**Student Name:** [Your Full Name] + +**GitHub Username:** @[YourGitHubUsername] + +--- + +### 📝 Summary of Changes + + +1. ... +2. ... +3. ... + +--- + +### ✅ Deliverables Checklist + + + +- [ ] **Branching:** Created a new branch for this assignment (e.g., `assignment-X`) and this PR targets my fork's `main` branch. +- [ ] **Code Implementation:** All required scripts/code changes have been implemented as per the assignment instructions. +- [ ] **Configuration Files:** `pyproject.toml`, `Makefile` or other configuration files updated if necessary. +- [ ] **Reflection Questions:** All reflection questions for this assignment are answered in the section below. +- [ ] **Screenshots:** Relevant screenshots (e.g., MLflow UI, API docs, Grafana dashboard) are included or linked below (if required by the assignment). +- [ ] **Peer Review:** This PR has been peer-reviewed (if applicable for this assignment). + +--- + +### 🤔 Reflection Questions & Answers + + + +Question 1: [Paste Assignment-Specific Question 1 Here] + +- [Your Answer Here] + +Question 2: [Paste Assignment-Specific Question 2 Here] + +- [Your Answer Here] + + + +--- + +### 📸 Screenshots / Outputs (if applicable) + + + +### ❓ Questions / Blockers / Points for Reviewer + + +### 🙋 Self-Review Checklist (Before Submitting for Peer or Instructor Review) + +- [ ] Assignment Requirements: I have re-read the assignment requirements and believe my submission meets them. +- [ ] Code Functionality: I have tested the core functionality of my changes locally. +- [ ] Code Quality Tools: + - [ ] `make format` (or `uv run ruff format .`) run: Code is formatted. + - [ ] `make lint` (or `uv run ruff check .`) run: No linting errors reported (or unavoidable ones are justified). + - [ ] `make type-check` (or `uv run mypy .`) run: No Mypy errors reported (or unavoidable ones are justified). +- [ ] Testing: `make test` (or `uv run pytest`) run: All tests pass. +- [ ] Clarity: My code is reasonably commented, and variable/function names are clear. +- [ ] PR Description: This PR description is fully filled out, including reflection answers. +- [ ] Commit History: My commit messages are descriptive and atomic where possible. +- [ ] No Sensitive Information: I have not committed any API keys, passwords, or other sensitive data. + +