Traffic Advisory Update if not seen. Wrong "O'Clock" quadrant added. #864
Open
Jud6969 wants to merge 1 commit into
Open
Traffic Advisory Update if not seen. Wrong "O'Clock" quadrant added. #864Jud6969 wants to merge 1 commit into
Jud6969 wants to merge 1 commit into
Conversation
mmp
reviewed
Apr 20, 2026
Owner
|
(Also, please run |
Contributor
Author
|
code should be formatted, from my end it is at least, let me know it if it is not |
Contributor
Author
|
Converting this to a draft since there were a lot of changes to the traffic advisory functions. |
Re-implements the original 5-commit traffic-advisory phraseology stack
on top of upstream's refactored event-queue + UnseenTrafficCall model.
Squashed (the original commits were chained edits to code that no
longer exists upstream).
What's added:
- aviation/intent.go: TrafficResponseWrongQuadrant + ActualOclock field
on TrafficAdvisoryIntent. Render uses the assertive form
("traffic at our N o'clock in sight"); no question form.
- sim/commands.go handleTrafficAdvisory: single-pass findAdvisoryTraffic
helper that classifies into exact / wrong-quadrant / none. Exact
unchanged. Wrong-quadrant records sighting and emits the new intent.
None schedules a "where's that traffic" follow-up via the
UnseenTrafficCall.WhereAskFireTime field.
- sim/aircraft.go: WhereAskFireTime added to UnseenTrafficCall. No new
queue or struct — piggy-backs on the existing per-call carrier.
- sim/sim.go updateState: per-tick check for elapsed WhereAskFireTime,
emits PendingTransmissionTrafficWhere. Also adds the missing
`continue` after the far-away-aircraft cull so the new check doesn't
run on a freshly-deleted pointer.
- sim/radio.go: PendingTransmissionTrafficWhere enum value and
GenerateContactTransmission case ("where's that traffic"...).
- sim/visual_approach_test.go: existing test assertion updated to allow
the where-ask UnseenTrafficCall (was: nil; now: just not the prior
DAL456 stale call).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Jud6969
force-pushed
the
traffic-advisory-phraseology
branch
from
52bbe9c to
6a14d0b
Compare
Contributor
Author
|
updated with the main branch. did some testing by putting two aircraft next to each other going the same altitude and direction, then had one guy behind trying to find one of the aircraft. testing worked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced from issue #824
Add two pilot-response variants: