Skip to content

Commit 570ec6e

Browse files
committed
Avoid configuring logging during MCPServer init
1 parent 3d7b311 commit 570ec6e

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

src/mcp/server/mcpserver/server.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
from mcp.server.mcpserver.resources import FunctionResource, Resource, ResourceManager
3737
from mcp.server.mcpserver.tools import Tool, ToolManager
3838
from mcp.server.mcpserver.utilities.context_injection import find_context_parameter
39-
from mcp.server.mcpserver.utilities.logging import configure_logging, get_logger
39+
from mcp.server.mcpserver.utilities.logging import get_logger
4040
from mcp.server.sse import SseServerTransport
4141
from mcp.server.stdio import stdio_server
4242
from mcp.server.streamable_http import EventStore
@@ -203,9 +203,6 @@ def __init__(
203203
self._token_verifier = ProviderTokenVerifier(auth_server_provider)
204204
self._custom_starlette_routes: list[Route] = []
205205

206-
# Configure logging
207-
configure_logging(self.settings.log_level)
208-
209206
@property
210207
def name(self) -> str:
211208
return self._lowlevel_server.name

tests/server/mcpserver/test_server.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import base64
2+
import logging
23
from pathlib import Path
34
from typing import Any
45
from unittest.mock import AsyncMock, MagicMock, patch
@@ -45,6 +46,15 @@
4546
pytestmark = pytest.mark.anyio
4647

4748

49+
async def test_create_server_does_not_configure_logging(monkeypatch: pytest.MonkeyPatch):
50+
basic_config = MagicMock()
51+
monkeypatch.setattr(logging, "basicConfig", basic_config)
52+
53+
MCPServer()
54+
55+
basic_config.assert_not_called()
56+
57+
4858
class TestServer:
4959
async def test_create_server(self):
5060
mcp = MCPServer(

0 commit comments

Comments
 (0)