Skip to content

Commit e9a7b4e

Browse files
author
RJ Lopez
committed
fix: revert lax coverage pragmas and cleanup identified covered blocks
1 parent f6c4620 commit e9a7b4e

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

src/mcp/client/session_group.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def __init__(
146146
self._session_exit_stacks = {}
147147
self._component_name_hook = component_name_hook
148148

149-
async def __aenter__(self) -> Self: # pragma: lax no cover
149+
async def __aenter__(self) -> Self:
150150
# Enter the exit stack only if we created it ourselves
151151
if self._owns_exit_stack:
152152
await self._exit_stack.__aenter__()
@@ -157,7 +157,7 @@ async def __aexit__(
157157
_exc_type: type[BaseException] | None,
158158
_exc_val: BaseException | None,
159159
_exc_tb: TracebackType | None,
160-
) -> bool | None: # pragma: lax no cover
160+
) -> bool | None:
161161
"""Closes session exit stacks and main exit stack upon completion."""
162162

163163
# Only close the main exit stack if we created it
@@ -237,13 +237,13 @@ async def disconnect_from_server(self, session: mcp.ClientSession) -> None:
237237
for name in component_names.tools:
238238
if name in self._tools: # pragma: no branch
239239
del self._tools[name]
240-
if name in self._tool_to_session: # pragma: lax no cover
240+
if name in self._tool_to_session: # pragma: no branch
241241
del self._tool_to_session[name]
242242

243243
# Clean up the session's resources via its dedicated exit stack
244244
if session_known_for_stack:
245-
session_stack_to_close = self._session_exit_stacks.pop(session) # pragma: lax no cover
246-
await session_stack_to_close.aclose() # pragma: lax no cover
245+
session_stack_to_close = self._session_exit_stacks.pop(session) # pragma: no cover
246+
await session_stack_to_close.aclose() # pragma: no cover
247247

248248
async def connect_with_session(
249249
self, server_info: types.Implementation, session: mcp.ClientSession
@@ -323,7 +323,7 @@ async def _establish_session(
323323
await self._exit_stack.enter_async_context(session_stack)
324324

325325
return result.server_info, session
326-
except Exception: # pragma: lax no cover
326+
except Exception:
327327
# If anything during this setup fails, ensure the session-specific
328328
# stack is closed.
329329
await session_stack.aclose()

src/mcp/shared/session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ async def _handle_session_message(message: SessionMessage) -> None:
451451
try:
452452
await stream.send(JSONRPCError(jsonrpc="2.0", id=id, error=error))
453453
await stream.aclose()
454-
except Exception: # pragma: lax no cover
454+
except Exception:
455455
# Stream might already be closed
456456
pass
457457
self._response_streams.clear()

tests/client/test_session_group.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
import sys
66
from unittest import mock
77

8-
if sys.version_info < (3, 11): # pragma: lax no cover
8+
if sys.version_info < (3, 11): # pragma: no cover
99
from exceptiongroup import BaseExceptionGroup
10-
else: # pragma: lax no cover
10+
else: # pragma: no cover
1111
BaseExceptionGroup = ExceptionGroup # type: ignore # noqa: F821
1212

1313
import httpx
@@ -449,7 +449,7 @@ async def test_unreachable_streamable_http_error_is_catchable() -> None:
449449
except BaseException as inner:
450450
# Expected post-fix: real ConnectError lands here.
451451
caught = inner
452-
except BaseException as outer: # pragma: lax no cover
452+
except BaseException as outer: # pragma: no cover
453453
# If we land here, the error escaped past the inner handler --
454454
# that is the regression case (masking RuntimeError surfacing
455455
# from __aexit__ instead of the real ConnectError propagating).

0 commit comments

Comments
 (0)