Skip to content

Commit 1336f34

Browse files
lesnik512claude
andcommitted
docs(spec): correct event-assertion note — no central registry test
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent b4ba5ae commit 1336f34

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

planning/specs/2026-06-13-circuit-breaker-and-timeout-design.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ tests/test_circuit_breaker.py # NEW — async
4848
tests/test_circuit_breaker_sync.py # NEW — sync mirror
4949
tests/test_circuit_breaker_props.py # NEW — hypothesis invariant (optional but specified)
5050
tests/test_errors.py # + CircuitOpenError fields/pickle
51-
tests/test_observability.py # + 5 new event names (centralized assertion)
51+
# (event names asserted in the feature test files above, not test_observability.py)
5252
docs/resilience.md # + CircuitBreaker + AsyncTimeout sections
5353
README.md # resilience paragraph
5454
planning/releases/0.10.0.md # NEW
@@ -290,7 +290,7 @@ TDD, 100% branch coverage enforced (`--cov-fail-under=100`). `httpx2.MockTranspo
290290

291291
**`tests/test_errors.py`:** `CircuitOpenError` is a `ClientError`, stores `retry_after`, summary string for both `None` and a float, pickle round-trip via `__reduce__` (mirror `test_bulkhead_full_error_pickleable`).
292292

293-
**`tests/test_observability.py`:** add the 5 new event names to the centralized event-name assertion.
293+
**Event-name assertions:** there is no central event-name registry test (`test_observability.py` only unit-tests the `_emit_event` helper), so the 5 new event names are asserted in their own feature test files via `caplog``circuit.opened`/`circuit.rejected` in `test_open_emits_opened_event_and_rejects`, `circuit.half_open`/`circuit.closed` in `test_reset_timeout_admits_probe_then_closes`, `timeout.exceeded` in `test_expiry_raises_httpware_timeout_chained_from_builtin`.
294294

295295
`# pragma: no cover` only for genuinely-unreachable invariant arms (e.g. the `_check_loop` inner race arm), matching the existing style.
296296

0 commit comments

Comments
 (0)