You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
contributing.md contradicted conventions.md on whether public-method
docstrings are unconditionally required, and understated what CI
machine-checks vs. overview.md's finer breakdown. Per maintainer
ruling: docstring requirement is unconditional, and both sections now
link to their truth-home files instead of restating them.
Copy file name to clipboardExpand all lines: planning/audits/2026-07-13-docs-comments-audit.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -63,12 +63,14 @@ Verified against source: the `try/except Exception: raise DecodeError(...)` live
63
63
`contributing.md`: `"Module docstrings are required; per-method docstrings only when types alone are insufficient."` (conditional)
64
64
`conventions.md`: `"Module / class / public-method docstrings are required ..."` (unconditional)
65
65
*Fix:* pick one policy and make both files say it — recommend keeping `conventions.md`'s unconditional wording since it's the capability truth home, and updating `contributing.md` to match.
66
+
**Resolved** (`2026-07-13.08`) — maintainer ruled unconditional; `contributing.md` now links to `conventions.md` instead of restating.
66
67
67
68
**I3 — `docs/dev/contributing.md:32-34` understates what CI machine-checks, vs `architecture/overview.md:9`.**
68
69
`contributing.md`: `"The CI lint pass (...) catches what the linters can see (e.g. print() via ruff T201); the rest are enforced in code review."` — reads as "only `print()` is machine-checked."
69
70
`overview.md`: documents two more checks contributing.md omits — `PGH003` (blanket `# type: ignore`) is machine-checked, and `SLF001` partially checks the `httpx2._` ban (attribute access, not import).
70
71
This is a fresh drift, not a re-flag of the 2026-06-13 audit's I1 (that finding was about a since-removed "CI grep gates" phrase, already fixed) — `overview.md`'s finer breakdown was apparently added after `contributing.md`'s wording was last touched.
71
72
*Fix:* replace `contributing.md`'s "the rest are enforced in code review" with the same three-tier breakdown `overview.md` uses (machine-checked / partially-checked / review-only), or have it link to `overview.md` instead of restating.
73
+
**Resolved** (`2026-07-13.08`) — maintainer ruled link-instead-of-restate, per the repo's truth-home principle.
72
74
73
75
**I4 — `docs/testing.md:110` says `httpx` where it means `httpx2`.**
74
76
`"MockTransport is the public test seam in httpx — supported by the maintainers, stable across versions ... respx patches private internals and has historically broken across httpx major versions."`
@@ -98,14 +100,12 @@ Same argument, ~3 near-identical sentences in each. Bundle this cleanup with the
summary: Fixed 2 verified wording contradictions from the docs-and-comments audit — contributing.md's docstring requirement now matches conventions.md (unconditional), and its CI-enforcement claim links to overview.md instead of restating a stale subset.
0 commit comments