From 738dedb85fb754b423ed24018912e5696ccecb52 Mon Sep 17 00:00:00 2001 From: Pavel Safronov Date: Tue, 7 Apr 2026 14:33:04 -0700 Subject: [PATCH 1/3] ci: skip failing Windows test --- test/integration/crud/find.test.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/test/integration/crud/find.test.ts b/test/integration/crud/find.test.ts index bb6fc2146e4..1be7db7fcf5 100644 --- a/test/integration/crud/find.test.ts +++ b/test/integration/crud/find.test.ts @@ -8,9 +8,11 @@ import { type MongoClient, MongoServerError, ObjectId, - ReturnDocument + ReturnDocument, + runNodelessTests } from '../../mongodb'; import { assert as test, filterForCommands } from '../shared'; +import { platform } from 'os'; describe('Find', function () { let client: MongoClient; @@ -1078,6 +1080,11 @@ describe('Find', function () { 'regression test (NODE-6878): CursorResponse.emptyGetMore contains all CursorResponse fields', { requires: { topology: 'sharded' } }, async function () { + if (platform() === 'win32') { + // TODO: NODE-7511 - unskip test for NODE-6878 in Windows + this.skip(); + } + const collection = client.db('rewind-regression').collection('bar'); await collection.deleteMany({}); From 1a7ededecc4e2f7bb548b311a29d12d78f0661ed Mon Sep 17 00:00:00 2001 From: Pavel Safronov Date: Tue, 7 Apr 2026 14:56:50 -0700 Subject: [PATCH 2/3] pr feedback: use a simpler conditional --- test/integration/crud/find.test.ts | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/test/integration/crud/find.test.ts b/test/integration/crud/find.test.ts index 1be7db7fcf5..46f9fbb0cdd 100644 --- a/test/integration/crud/find.test.ts +++ b/test/integration/crud/find.test.ts @@ -8,11 +8,9 @@ import { type MongoClient, MongoServerError, ObjectId, - ReturnDocument, - runNodelessTests + ReturnDocument } from '../../mongodb'; import { assert as test, filterForCommands } from '../shared'; -import { platform } from 'os'; describe('Find', function () { let client: MongoClient; @@ -1078,13 +1076,9 @@ describe('Find', function () { it( 'regression test (NODE-6878): CursorResponse.emptyGetMore contains all CursorResponse fields', - { requires: { topology: 'sharded' } }, + // TODO: NODE-7511 - unskip test for NODE-6878 in Windows + { requires: { topology: 'sharded', os: '!win32' } }, async function () { - if (platform() === 'win32') { - // TODO: NODE-7511 - unskip test for NODE-6878 in Windows - this.skip(); - } - const collection = client.db('rewind-regression').collection('bar'); await collection.deleteMany({}); From 35209391b767f65eca5b185f0622e9d5fbb9f8e3 Mon Sep 17 00:00:00 2001 From: Pavel Safronov Date: Wed, 8 Apr 2026 12:25:05 -0700 Subject: [PATCH 3/3] skip test against mongodb 9 and higher --- test/integration/crud/find.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/integration/crud/find.test.ts b/test/integration/crud/find.test.ts index 46f9fbb0cdd..cbd84697f80 100644 --- a/test/integration/crud/find.test.ts +++ b/test/integration/crud/find.test.ts @@ -1076,8 +1076,8 @@ describe('Find', function () { it( 'regression test (NODE-6878): CursorResponse.emptyGetMore contains all CursorResponse fields', - // TODO: NODE-7511 - unskip test for NODE-6878 in Windows - { requires: { topology: 'sharded', os: '!win32' } }, + // TODO: NODE-7511 - unskip test for NODE-6878 + { requires: { topology: 'sharded', mongodb: '<9' } }, async function () { const collection = client.db('rewind-regression').collection('bar');