refactor: solid personal bests modal (@d1rshan)#8009
Conversation
| </thead> | ||
| <For each={groups()}> | ||
| {(group) => ( | ||
| <tbody class="[clip-path:inset(0)]"> |
There was a problem hiding this comment.
[&>tr:nth-child(odd)>td]:bg-sub-alt should do the row backgrounds
| setGroups(buildGroups(mode())); | ||
| }} | ||
| > | ||
| <table class="border-collapse border-spacing-0 text-text"> |
There was a problem hiding this comment.
I am wondering, besides the sticky is there anything special on this table preventing us from using the DataTable like we do in the other components?
There was a problem hiding this comment.
im not sure, will look at the component and refactor pb tables to use that. i think it should be possible.
| return ( | ||
| <AnimatedModal | ||
| id="PbTables" | ||
| modalClass="max-w-full gap-0 overflow-y-scroll overscroll-y-contain p-8" |
There was a problem hiding this comment.
is one of the classes the fix for the scroll issue? should we set it by default in the AnimatedModal component?
There was a problem hiding this comment.
yes, the overscroll-y-contain class is the fix for scroll issue and i think we should add it to animated modal since all modals need the same behavior.
will update it.
3 participants
Uh oh!
There was an error while loading. Please reload this page.