are there plans to add preview thumbnails support in osc,

Expected behavior of the wanted feature

i know there is this thumbfast script for thumbnail but it is quite old, so i wanted to know are there any plans to add official thumbnail support

i use default mpv osc not other custom ones

Alternative behavior of the wanted feature

No response

Log File

No response

Sample Files

No response

[verygoodlee]

#14458

[guidocella]

po5/thumbfast#149 (comment)

[N-R-K]

This is a common enough use case that it makes sense to support (or at least have mechanisms for) it natively.

thumbfast works but it's gnarly, it spawns a different mpv process to do the thumbnailing, which can sometimes run into issues when the two process don't render the same way. It's also why thumbnails on network playback is disabled by default. Having some kind of thumbnailing mechanism natively would avoid these issues as the thumbnail would be created by the same process.

[kasper93]

Practically speaking, spawning 2nd mpv process and getting the screenshot at the requested timestamp is the correct way of doing it. In-process alternative would be a lot of glue code that basically is spawning the 2nd demux/decode and so on. We don't want to interrupt main playback loop.

[CounterPillow]

Considering this adds a whole background encoding process to mpv that shits up the disk, it should stay in a script people can choose to install rather than making it yet another default that will cause people to report performance issues

[kasper93]

I already said that on IRC some time ago. I think osc.lua should expose an api/entry point to which can be used by thumbnail provider scripts to display them. Method of extracting may vary.

[CounterPillow]

Yes, I think making the osc.lua more extensible without a full replacement is the right solution. It's a file that sees a lot of activity, so it would be ideal if scripts didn't have to copy and modify it. But please keep mpv from doing horrendously expensive stateful background nonsense.

[guidocella]

thumbfast only writes the current thumbnail to disk, and a C implementation could get even that from memory. (overlay-add does accept a memory address but you can't get the memory address of screenshot-raw's return value from a script.)
For youtube thumbnails the process is completely different consisting of downloading the pre-generated thumbnails.

master...Lypheo:mpv:master has a native implementation which shows thumbnails only from cached areas.

[N-R-K]

In-process alternative would be a lot of glue code that basically is spawning the 2nd demux/decode and so on. We don't want to interrupt main playback loop.

But please keep mpv from doing horrendously expensive stateful background nonsense.

Ah yes, the unsolved problem of displaying thumbnails without interrupting playback, such a shame that no known video player has managed to solve this issue.

[kasper93]

master...Lypheo:mpv:master has a native implementation which shows thumbnails only from cached areas.

Ah, yes, nihing custom decoder and running libmpv client inside mpv process.

[kasper93]

Ah yes, the unsolved problem of displaying thumbnails without interrupting playback, such a shame that no known video player has managed to solve this issue.

PR are welcome. I would like to see how do you solve this problem without overhead.

[N-R-K]

PR are welcome. I would like to see how do you solve this problem without overhead.

I don't doubt that it's non trivial, and #14458 (comment) mentions lack of interest from (volunteer) developers which is also a valid excuse.

But presenting it as some sort of herculean task when nearly every single worthwhile video player already has this functionality is just as ridiculous as gnome devs explaining why their filepicker cannot show thumbnails.

[kasper93]

But presenting it as some sort of herculean task

On the contrary. It's easy task, that is solved in multiple ways. You have probably 10 different scripts for mpv to achieve this feature.