From 364abc83c88298e99438d2cae7ba65b01eb1bb3e Mon Sep 17 00:00:00 2001 From: mrveiss Date: Mon, 23 Mar 2026 19:17:22 +0200 Subject: [PATCH] refactor(tests): migrate legacy redis_client imports to autobot_shared (#2047) Replace all `from utils.redis_client` imports in backend test files with the canonical `from autobot_shared.redis_client` pattern. Leaves string literals in redis_optimizer_test.py untouched as they are test fixtures. --- autobot-backend/async_baseline.performance_test.py | 2 +- autobot-backend/monitoring/redis_prometheus_metrics_test.py | 3 ++- autobot-backend/services/redis_listeners.e2e_test.py | 3 ++- autobot-backend/utils/redis_consolidation_test.py | 4 ++-- autobot-backend/utils/redis_thread_safety_test.py | 5 +++-- 5 files changed, 10 insertions(+), 7 deletions(-) diff --git a/autobot-backend/async_baseline.performance_test.py b/autobot-backend/async_baseline.performance_test.py index 9b750f65f..255ceb301 100644 --- a/autobot-backend/async_baseline.performance_test.py +++ b/autobot-backend/async_baseline.performance_test.py @@ -35,7 +35,7 @@ from constants.network_constants import NetworkConstants, ServiceURLs # Import canonical Redis client pattern -from utils.redis_client import get_redis_client +from autobot_shared.redis_client import get_redis_client # Configure logging logging.basicConfig( diff --git a/autobot-backend/monitoring/redis_prometheus_metrics_test.py b/autobot-backend/monitoring/redis_prometheus_metrics_test.py index b123c7622..3bdf03bfa 100644 --- a/autobot-backend/monitoring/redis_prometheus_metrics_test.py +++ b/autobot-backend/monitoring/redis_prometheus_metrics_test.py @@ -7,7 +7,8 @@ import pytest from monitoring.prometheus_metrics import get_metrics_manager -from utils.redis_client import RedisConnectionManager + +from autobot_shared.redis_client import RedisConnectionManager @pytest.fixture diff --git a/autobot-backend/services/redis_listeners.e2e_test.py b/autobot-backend/services/redis_listeners.e2e_test.py index 6e243de93..206dec3a8 100644 --- a/autobot-backend/services/redis_listeners.e2e_test.py +++ b/autobot-backend/services/redis_listeners.e2e_test.py @@ -10,7 +10,8 @@ import redis from config import config as global_config_manager -from utils.redis_client import get_redis_client + +from autobot_shared.redis_client import get_redis_client def test_worker_capabilities(): diff --git a/autobot-backend/utils/redis_consolidation_test.py b/autobot-backend/utils/redis_consolidation_test.py index 9b00acd59..14001bb05 100644 --- a/autobot-backend/utils/redis_consolidation_test.py +++ b/autobot-backend/utils/redis_consolidation_test.py @@ -11,7 +11,7 @@ sys.path.insert(0, str(Path(__file__).parent.parent)) -from utils.redis_client import ( +from autobot_shared.redis_client import ( ConnectionState, ManagerStats, PoolStatistics, @@ -255,7 +255,7 @@ def test_circuit_breaker_logic(self): def test_module_imports(): """Test all expected exports are available""" - from utils import redis_client + from autobot_shared import redis_client # Check all main exports assert hasattr(redis_client, "get_redis_client") diff --git a/autobot-backend/utils/redis_thread_safety_test.py b/autobot-backend/utils/redis_thread_safety_test.py index 0133f823f..9ad7a6ab1 100644 --- a/autobot-backend/utils/redis_thread_safety_test.py +++ b/autobot-backend/utils/redis_thread_safety_test.py @@ -13,7 +13,8 @@ from unittest.mock import MagicMock, Mock, patch import pytest -from utils.redis_client import RedisConnectionManager + +from autobot_shared.redis_client import RedisConnectionManager class TestPoolStatisticsThreadSafety: @@ -275,7 +276,7 @@ async def test_cleanup_doesnt_affect_active_connections(self): # Use freezegun or manual datetime mocking # Mock datetime.now() to return consistent value - import utils.redis_client as redis_client_module + import autobot_shared.redis_client as redis_client_module original_datetime = redis_client_module.datetime