From 54a2c52c740615f4331241b418815294fd5d03af Mon Sep 17 00:00:00 2001 From: Kai Nagel Date: Mon, 20 Apr 2026 23:10:58 +0200 Subject: [PATCH 1/4] comment-out verify-all-jobs-successful in ci.yml --- .github/workflows/ci.yml | 42 ++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 20e20ac3e..7d56ec74b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -76,24 +76,24 @@ jobs: # the following is what matsim-libs has. Don't know why it is needed. kai, apr'26 - verify-all-jobs-successful: - # always() - to ensure this job is executed (regardless of the status of the previous job) - # run if push or pull_requests from fork - if: always() && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository) - needs: build - runs-on: ubuntu-latest - - # When running this workflow for internal PRs "verify-all-jobs-successful" is marked as skipped, - # which GitHub takes as a green flag and will allow merging before "verify-all-jobs-successful" - # is completed for the push event. - # One way to avoid this is to create a job from a matrix on the fly. They will be created for - # push events and PR events from forks (but not for PR events coming from internal forks), - # so we can safely add a check "verify-all-jobs-successful (push-or-external-PR)" - strategy: - matrix: - name: [ "push-or-external-PR" ] - - steps: - - name: check if the whole job matrix is successful - if: needs.build.result != 'success' - run: exit 1 # fail if "build" was not successful + # verify-all-jobs-successful: + # # always() - to ensure this job is executed (regardless of the status of the previous job) + # # run if push or pull_requests from fork + # if: always() && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository) + # needs: build + # runs-on: ubuntu-latest + + # # When running this workflow for internal PRs "verify-all-jobs-successful" is marked as skipped, + # # which GitHub takes as a green flag and will allow merging before "verify-all-jobs-successful" + # # is completed for the push event. + # # One way to avoid this is to create a job from a matrix on the fly. They will be created for + # # push events and PR events from forks (but not for PR events coming from internal forks), + # # so we can safely add a check "verify-all-jobs-successful (push-or-external-PR)" + # strategy: + # matrix: + # name: [ "push-or-external-PR" ] + + # steps: + # - name: check if the whole job matrix is successful + # if: needs.build.result != 'success' + # run: exit 1 # fail if "build" was not successful From 3ce46e44c76f166b4e04d1e63b2b9cacc329876f Mon Sep 17 00:00:00 2001 From: Kai Nagel Date: Mon, 20 Apr 2026 23:16:08 +0200 Subject: [PATCH 2/4] re-add the verify ... block --- .github/workflows/ci.yml | 42 ++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7d56ec74b..20e20ac3e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -76,24 +76,24 @@ jobs: # the following is what matsim-libs has. Don't know why it is needed. kai, apr'26 - # verify-all-jobs-successful: - # # always() - to ensure this job is executed (regardless of the status of the previous job) - # # run if push or pull_requests from fork - # if: always() && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository) - # needs: build - # runs-on: ubuntu-latest - - # # When running this workflow for internal PRs "verify-all-jobs-successful" is marked as skipped, - # # which GitHub takes as a green flag and will allow merging before "verify-all-jobs-successful" - # # is completed for the push event. - # # One way to avoid this is to create a job from a matrix on the fly. They will be created for - # # push events and PR events from forks (but not for PR events coming from internal forks), - # # so we can safely add a check "verify-all-jobs-successful (push-or-external-PR)" - # strategy: - # matrix: - # name: [ "push-or-external-PR" ] - - # steps: - # - name: check if the whole job matrix is successful - # if: needs.build.result != 'success' - # run: exit 1 # fail if "build" was not successful + verify-all-jobs-successful: + # always() - to ensure this job is executed (regardless of the status of the previous job) + # run if push or pull_requests from fork + if: always() && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository) + needs: build + runs-on: ubuntu-latest + + # When running this workflow for internal PRs "verify-all-jobs-successful" is marked as skipped, + # which GitHub takes as a green flag and will allow merging before "verify-all-jobs-successful" + # is completed for the push event. + # One way to avoid this is to create a job from a matrix on the fly. They will be created for + # push events and PR events from forks (but not for PR events coming from internal forks), + # so we can safely add a check "verify-all-jobs-successful (push-or-external-PR)" + strategy: + matrix: + name: [ "push-or-external-PR" ] + + steps: + - name: check if the whole job matrix is successful + if: needs.build.result != 'success' + run: exit 1 # fail if "build" was not successful From b07c664cb97c330cfbb364b4d91e7c767c69bdef Mon Sep 17 00:00:00 2001 From: Kai Nagel Date: Mon, 20 Apr 2026 23:46:27 +0200 Subject: [PATCH 3/4] try some other aggregation method (from chatgpt) --- .github/workflows/ci.yml | 50 ++++++++++++++++++++++++---------------- 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 20e20ac3e..4074fe6dd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -74,26 +74,36 @@ jobs: env: MAVEN_OPTS: -Xmx2g -# the following is what matsim-libs has. Don't know why it is needed. kai, apr'26 - - verify-all-jobs-successful: - # always() - to ensure this job is executed (regardless of the status of the previous job) - # run if push or pull_requests from fork - if: always() && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository) - needs: build + test_all: runs-on: ubuntu-latest + needs: build + if: always() + steps: + - run: | + if [[ "${{ needs.build.result }}" != "success" ]]; then + exit 1 + fi - # When running this workflow for internal PRs "verify-all-jobs-successful" is marked as skipped, - # which GitHub takes as a green flag and will allow merging before "verify-all-jobs-successful" - # is completed for the push event. - # One way to avoid this is to create a job from a matrix on the fly. They will be created for - # push events and PR events from forks (but not for PR events coming from internal forks), - # so we can safely add a check "verify-all-jobs-successful (push-or-external-PR)" - strategy: - matrix: - name: [ "push-or-external-PR" ] +# the following is what matsim-libs has. Don't know why it is needed. kai, apr'26 - steps: - - name: check if the whole job matrix is successful - if: needs.build.result != 'success' - run: exit 1 # fail if "build" was not successful + # verify-all-jobs-successful: + # # always() - to ensure this job is executed (regardless of the status of the previous job) + # # run if push or pull_requests from fork + # if: always() && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository) + # needs: build + # runs-on: ubuntu-latest + + # # When running this workflow for internal PRs "verify-all-jobs-successful" is marked as skipped, + # # which GitHub takes as a green flag and will allow merging before "verify-all-jobs-successful" + # # is completed for the push event. + # # One way to avoid this is to create a job from a matrix on the fly. They will be created for + # # push events and PR events from forks (but not for PR events coming from internal forks), + # # so we can safely add a check "verify-all-jobs-successful (push-or-external-PR)" + # strategy: + # matrix: + # name: [ "push-or-external-PR" ] + + # steps: + # - name: check if the whole job matrix is successful + # if: needs.build.result != 'success' + # run: exit 1 # fail if "build" was not successful From 4fd915519350e22facde7528b6a95f6e2e8a259b Mon Sep 17 00:00:00 2001 From: kainagel Date: Tue, 21 Apr 2026 19:15:24 +0200 Subject: [PATCH 4/4] Update ci.yml --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4074fe6dd..644f92f44 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,7 +5,7 @@ on: branches: [ master ] pull_request: branches: [ master ] - + merge_group: jobs: build: