bugfix: binary file diff panic #131
Closed
asyncawaitpromise wants to merge 0 commit into
Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
BakerNet
force-pushed
the
bugfix/binary-file-diff-panic
branch
from
d060f9c to
d5f760f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
PE-887
Summary / Background
A production PR with a binary file mode change caused codeowners-plus to panic when parsing the diff.
The git output for a mode change combined with a binary patch produces a FileDiff that the upstream go-diff parser leaves with empty OrigName and NewName. The old code then tried to slice the empty name and crashed.
This change recovers the filename from the diff --git extended header when the standard name fields are empty, and adds a regression test that pins the exact production diff shape.
Testing
Reproduced the panic against the original triggering diff. Parsed the raw diff through go-diff and confirmed the function on main panics with the exact stack trace from the ticket on the mode change plus binary patch entry.
Verified the fix. The same FileDiff that previously panicked now returns the correct filename instead of crashing.
Added a regression test using the exact production diff shape (synthetic file paths). Reverting diff.go to the previous version makes the test panic with the same stack trace, which confirms the test guards the right behavior. The full internal/git test suite passes.