Skip to content

bugfix: binary file panic#132

Merged
asyncawaitpromise merged 1 commit into
mainfrom
bugfix/binary-file-panic
May 20, 2026
Merged

bugfix: binary file panic#132
asyncawaitpromise merged 1 commit into
mainfrom
bugfix/binary-file-panic

Conversation

@asyncawaitpromise
Copy link
Copy Markdown
Collaborator

@asyncawaitpromise asyncawaitpromise commented May 20, 2026

Summary / Background

A production PR with a binary file mode change caused codeowners-plus to panic when parsing the diff.

The git output for a mode change combined with a binary patch produces a FileDiff that the upstream go-diff parser leaves with empty OrigName and NewName. The old code then tried to slice the empty name and crashed.

This change recovers the filename from the diff --git extended header when the standard name fields are empty, and adds a regression test that pins the exact production diff shape.

Testing

Reproduced the panic against the original triggering diff. Parsed the raw diff through go-diff and confirmed the function on main panics with the exact stack trace from the ticket on the mode change plus binary patch entry.

Verified the fix. The same FileDiff that previously panicked now returns the correct filename instead of crashing.

Added a regression test using the exact production diff shape (synthetic file paths). Reverting diff.go to the previous version makes the test panic with the same stack trace, which confirms the test guards the right behavior. The full internal/git test suite passes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Codeowners approval required for this PR:

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the git diff parsing logic to correctly identify filenames for binary files by extracting them from the extended "diff --git" header when standard headers are absent. It also includes a fix for a potential panic during mode changes and adds several test cases to verify binary file handling, quoted paths, and renames. I have no feedback to provide.

@asyncawaitpromise asyncawaitpromise force-pushed the bugfix/binary-file-panic branch from c2d0f16 to 202555a Compare May 20, 2026 17:30
@asyncawaitpromise asyncawaitpromise merged commit 17f39bf into main May 20, 2026
9 of 10 checks passed
@asyncawaitpromise asyncawaitpromise deleted the bugfix/binary-file-panic branch May 20, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants