v1.9.1#133
Conversation
|
Codeowners approval required for this PR: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the codeowners-plus action version in the README to v1.9.1 and increments the CLI version in tools/cli/main.go. A review comment points out a version mismatch, suggesting that the CLI version should be set to v1.9.1 instead of v1.9.2.dev to align with the release documentation and ensure the compiled binary reports the correct version.
| Name: "codeowners-cli", | ||
| Usage: "CLI tool for working with .codeowners files", | ||
| Version: "v1.9.1.dev", | ||
| Version: "v1.9.2.dev", |
There was a problem hiding this comment.
The version is being bumped to v1.9.2.dev, but the pull request title and README updates indicate this is the release for v1.9.1. If this is the release PR, the version in the code should be set to v1.9.1. Skipping the release version in the code means the compiled binary for v1.9.1 will incorrectly report itself as a development build for v1.9.2.
| Version: "v1.9.2.dev", | |
| Version: "v1.9.1", |
1 participant
Post v1.9.1