Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
fetch-depth: 0

- name: 'Codeowners Plus'
uses: multimediallc/codeowners-plus@v1.9.0
uses: multimediallc/codeowners-plus@v1.9.1
with:
github-token: '${{ secrets.GITHUB_TOKEN }}'
pr: '${{ github.event.pull_request.number }}'
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func main() {
app := &cli.Command{
Name: "codeowners-cli",
Usage: "CLI tool for working with .codeowners files",
Version: "v1.9.1.dev",
Version: "v1.9.2.dev",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version is being bumped to v1.9.2.dev, but the pull request title and README updates indicate this is the release for v1.9.1. If this is the release PR, the version in the code should be set to v1.9.1. Skipping the release version in the code means the compiled binary for v1.9.1 will incorrectly report itself as a development build for v1.9.2.

Suggested change
Version: "v1.9.2.dev",
Version: "v1.9.1",

Description: "",
Commands: []*cli.Command{
{
Expand Down
Loading