feat(expr-ir): Long-overdue sync#3611
Merged
Merged
Conversation
Thought it looked a bit weird in a doctest Turns out they use `()` in `Expr::BinaryExpr`, but never in `Selector::*` - https://github.com/pola-rs/polars/blob/7fc9f1875714fe9893c4d849b9593c1e4db1e854/crates/polars-plan/src/dsl/format.rs#L87 - https://github.com/pola-rs/polars/blob/7fc9f1875714fe9893c4d849b9593c1e4db1e854/crates/polars-plan/src/dsl/selector.rs#L641-L644
Not sure why this only came up recently
Couldn't get coverage for `AllDType`, `EmptyDType`
Documenting this is one of the last selectors parts in #3497 May as well pick the name first
+ finish the partial API + use it everywhere
Wasn't possible in the (earlier) ADT version
Towards #3497 Highlights how this is based on the updated `polars` internals (pola-rs/polars#23351)
Towards #3497 - pylance added support recently (can't find when) for the text showing in both `__init__` and on attribute access - there's still some larger docs I wanna keep on the attributes *for now*
Towards #3497 getting there indeed
The time it would take to add tests is the only thing blocking these
- Planning to partially revert (#3029 (comment)) - I made the wrong call on `when` - Still prefer the deviation for the other nodes
- Avoids the double zipping - Covers the only valid expansion on `main` - + allows the expansion on a leaf
- Per-class (`{Binary,Ternary}Expr`), a cache hit can come from any instance
- This triggers another `(1, M, M)` case
added too much complexity for some that avoids a 2-3 string list
I'm adding a common base for `Lit`, `LitSeries`, `Col`, `LenStar` This was just in the way
- Truly the most insane commit (apologies future reader) - Changes a very core assumption - that everywhere can access `__narwhals_namespace__`
dangotbanned
added
documentation
maybe fixes: > TypeError: Parameters to generic types must be types. Got <narwhals._plan.translate.ParamSpec object at 0x7f72e4cf4dc0>.
> TypeError: type.__new__() takes exactly 3 arguments (0 given)
> fixture 'lazyframe' not found > fixture 'lazy' not found
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
Had hoped to split this up, but need to get something in before (#3608)
Related issues
ExprIR #2572ExprIR#3497