fix(expr-ir): Add compat for old polars#3617
Merged
Merged
Conversation
Needing to compare them now, but `Implementation` is never part of it
`test_linear_space_values` generates a bunch of tests, so skipping seems more reasonable
for more information, see https://pre-commit.ci
…ev/narwhals into expr-ir/polars-compat
At leats I hope that's all
Thinking it''l solve >AttributeError: partially initialized module 'polars' has no attribute '_cpu_check' (most likely due to a circular import))
This reverts commit 8a719a8. I think I found where the issue was fixed though (pola-rs/polars#24610)
This should avoid the pre-`1.34.0` bug, while still keeping most of the tests the same
Due to (bf2dd72) this is now more complex to test, so I'm dropping it
Still don't know why this is on `main`, but oh well - can add again if it comes up
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Among maybe one or two other things, (#3611) made a dent into adding
polarssupport.This one should clean up some of the mess I made
Related issues
ExprIR #2572Tasks
polarscompatoverpivotcollect_schemasort(nulls_last=...)linear_spacehas_nullsis_nanis_not_nanpl.lenover(order_by=...)on>=1.0.0; <1.30.0polarscompatAttributeError: partially initialized module 'polars' has no attribute '_cpu_check' (most likely due to a circular import))Follow-ups to get CI fully green
These are entirely unrelated to
polarsImmutable.__replace__pre-3.13