Skip to content

fix(expr-ir): Backport __replace__ typing for <3.13#3620

Merged
dangotbanned merged 7 commits into
oh-nodesfrom
expr-ir/typing/fix-replace
May 13, 2026
Merged

fix(expr-ir): Backport __replace__ typing for <3.13#3620
dangotbanned merged 7 commits into
oh-nodesfrom
expr-ir/typing/fix-replace

Conversation

@dangotbanned
Copy link
Copy Markdown
Member

Description

Aiming to fix this noise:

./.venv/bin/uv run --no-sync pyright
/home/runner/work/narwhals/narwhals/narwhals/_plan/_nodes.py
  /home/runner/work/narwhals/narwhals/narwhals/_plan/_nodes.py:528:33 - error: Cannot access attribute "__replace__" for class "ExprIR"
    Attribute "__replace__" is unknown (reportAttributeAccessIssue)
  /home/runner/work/narwhals/narwhals/narwhals/_plan/_nodes.py:533:28 - error: Cannot access attribute "__replace__" for class "ExprIR"
    Attribute "__replace__" is unknown (reportAttributeAccessIssue)
  /home/runner/work/narwhals/narwhals/narwhals/_plan/_nodes.py:636:28 - error: Cannot access attribute "__replace__" for class "ExprIR"
    Attribute "__replace__" is unknown (reportAttributeAccessIssue)
  /home/runner/work/narwhals/narwhals/narwhals/_plan/_nodes.py:648:43 - error: Cannot access attribute "__replace__" for class "ExprIR"
    Attribute "__replace__" is unknown (reportAttributeAccessIssue)
  /home/runner/work/narwhals/narwhals/narwhals/_plan/_nodes.py:661:36 - error: Cannot access attribute "__replace__" for class "ExprIR"
    Attribute "__replace__" is unknown (reportAttributeAccessIssue)
  /home/runner/work/narwhals/narwhals/narwhals/_plan/_nodes.py:686:33 - error: Cannot access attribute "__replace__" for class "ExprIR"
    Attribute "__replace__" is unknown (reportAttributeAccessIssue)
/home/runner/work/narwhals/narwhals/narwhals/_plan/expressions/function_expr.py
  /home/runner/work/narwhals/narwhals/narwhals/_plan/expressions/function_expr.py:122:24 - error: Cannot access attribute "__replace__" for class "FunctionExpr[FunctionT_co@FunctionExpr]*"
    Attribute "__replace__" is unknown (reportAttributeAccessIssue)
/home/runner/work/narwhals/narwhals/narwhals/_plan/plans/conversion.py
  /home/runner/work/narwhals/narwhals/narwhals/_plan/plans/conversion.py:552:57 - error: Cannot access attribute "__replace__" for class "SortMultipleOptions"
    Attribute "__replace__" is unknown (reportAttributeAccessIssue)
8 errors, 0 warnings, 0 informations

Related issues

Comment thread pyproject.toml
@dangotbanned dangotbanned marked this pull request as ready for review May 13, 2026 18:33
@dangotbanned dangotbanned merged commit 474882c into oh-nodes May 13, 2026
35 of 38 checks passed
@dangotbanned dangotbanned deleted the expr-ir/typing/fix-replace branch May 13, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant