Skip to content

Fix GBA serial timings to pass serial timing tests #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SourMesen merged 1 commit into from
May 16, 2026
+2 −0
Merged

Fix GBA serial timings to pass serial timing tests #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Core/GBA/GbaSerial.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ class GbaSerial final : public ISerializable
if(active && !_state.Active) {
_state.StartMasterClock = _memoryManager->GetMasterClock();
_state.EndMasterClock = _state.StartMasterClock + (_state.InternalShiftClockSpeed2MHz ? 8 : 64) * (_state.TransferWord ? 32 : 8);
_state.EndMasterClock += 6;
if(_state.IrqEnabled) {
_state.IrqMasterClock = _state.EndMasterClock;
_memoryManager->SetPendingUpdateFlag();
Expand All @@ -156,6 +157,7 @@ class GbaSerial final : public ISerializable
if(_state.StartMasterClock == _memoryManager->GetMasterClock()) {
//Update end based on params
_state.EndMasterClock = _state.StartMasterClock + (_state.InternalShiftClockSpeed2MHz ? 8 : 64) * (_state.TransferWord ? 32 : 8);
_state.EndMasterClock += 6;
}
if(_state.IrqEnabled) {
_state.IrqMasterClock = _state.EndMasterClock;
Expand Down
Loading