App crashes when sorting by newest when choosing files to upload

[JonathanPJL]

⚠️ Before posting ⚠️

• This is a bug, not a question or an enhancement.
• I've searched for similar issues and didn't find a duplicate.
• I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
• I agree to follow Nextcloud's Code of Conduct.

Steps to reproduce

1. I press the + button and press upload files.
2. I choose sort by newest first and it crashes.

Expected behaviour

I should be able to sort by newest first without the app crashing.

Actual behaviour

The app crashes when I try to sort by newest first. Some of the files are actually sorted already, but aren't appearing, so when I press newest first, it tries to fetch and load and sort, but immediately crashes.

Android version

16

Device brand and model

Samsung A36

Stock or custom OS?

Stock

Nextcloud android app version

30340190

Nextcloud server version

32.0.3

Using a reverse proxy?

Yes

Android logs

Cause of error

Exception in thread "pool-22-thread-1" java.util.ConcurrentModificationException
    at java.util.ArrayList.sort(ArrayList.java:1823)
    at java.util.Collections.sort(Collections.java:207)
    at kotlin.collections.CollectionsKt__MutableCollectionsJVMKt.sortWith(MutableCollectionsJVM.kt:42)
    at com.owncloud.android.utils.FileSortOrderByDate.sortLocalFiles(FileSortOrderByDate.kt:51)
    at com.owncloud.android.ui.adapter.LocalFileListAdapter.lambda$setSortOrder$6(LocalFileListAdapter.java:392)
    at com.owncloud.android.ui.adapter.LocalFileListAdapter.$r8$lambda$WTDJyclhOx9wYl9P9c9Mv0A876o(Unknown Source:0)
    at com.owncloud.android.ui.adapter.LocalFileListAdapter$$ExternalSyntheticLambda3.run(D8$$SyntheticClass:0)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
    at java.lang.Thread.run(Thread.java:1119)

App information

• ID: com.nextcloud.client
• Version: 30340190
• Build flavor: gplay

Device information

• Brand: samsung
• Device: a36xq
• Model: SM-A366U1
• Id: BP2A.250605.031.A3
• Product: a36xque

Firmware

• SDK: 36
• Release: 16
• Incremental: A366U1UES4BYK3

Server error logs

Additional information

No response

[laikoni]

Same for me when sorting from Z to A. It also looks like files are missing or are not sorted correctly before, as I only changed the sort order because the most recent photos did not appear at the top even though the sorting was by "most recent".

Cause of error

Exception in thread "pool-31-thread-1" java.util.ConcurrentModificationException
    at java.util.ArrayList.sort(ArrayList.java:1823)
    at java.util.Collections.sort(Collections.java:207)
    at kotlin.collections.CollectionsKt__MutableCollectionsJVMKt.sortWith(MutableCollectionsJVM.kt:42)
    at com.owncloud.android.utils.FileSortOrderByName.sortLocalFiles(FileSortOrderByName.kt:60)
    at com.owncloud.android.ui.adapter.LocalFileListAdapter.lambda$setSortOrder$6(LocalFileListAdapter.java:392)
    at com.owncloud.android.ui.adapter.LocalFileListAdapter.$r8$lambda$WTDJyclhOx9wYl9P9c9Mv0A876o(Unknown Source:0)
    at com.owncloud.android.ui.adapter.LocalFileListAdapter$$ExternalSyntheticLambda3.run(D8$$SyntheticClass:0)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
    at java.lang.Thread.run(Thread.java:1119)

App information

• ID: com.nextcloud.client
• Version: 30340190
• Build flavor: gplay

Device information

• Brand: Fairphone
• Device: FP5
• Model: FP5
• Id: AQ3A.240912.001
• Product: FP5

Firmware

• SDK: 35
• Release: 15
• Incremental: VT2I

[gohrner]

For documentation:

Duplicates of the sorting crash:

• Mobile app crashes when sorting on trying to upload files #16300
• crash when selecting file for upload #16250
• App crashes when sorting by newest when choosing files to upload #16192
• Crash while trying to order photos, to select which to upload #16013
• Bug when changing the file ordering criteria #15969

Well possible that I missed some...

This issue does not seem to have any priority, even though it makes the file upload feature something between really inconvenient to use to basically useless...

Incorrect file ordering when opening the file share view:

• Upload file does not show the latest file – regardless of which sorting option I choose #16190

[alperozturk96]

Solved with #15985 will be released via 3.35.0