Skip to content

Deleted or trashed folders still appear in teams view #2408

@benjaminfrueh

Description

@benjaminfrueh

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

When a folder shared with a team is deleted or moved to the trashbin, it still appears in the Teams view. Clicking it results in a "File not found" error. This affects places that fetch and display team resources using /ocs/v2.php/teams/{circleId}/resources e. g. the Teams Files list in Contacts / Teams. For the trashbin this persists until the trash is cleared, for deleted files they are displayed until the DeleteOrphanedSharesJob cleans the shares without files.

Steps to reproduce

  1. Create a team
  2. Create a folder, share it with the team, either directly or in Contacts / Teams / Create Folder
  3. Delete the folder (optionally also empty the trashbin)
  4. The folder is still listed in Contacts / Teams in the Files list
  5. Clicking it shows "File not found"

Expected behaviour

Folders that no longer exist or are in the trashbin should not be shown in the files list.

Actual behaviour

The view lists all circle shares from the database without checking whether the underlying file is still accessible, resulting in broken entries being shown.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions