Allow ignoring specific files using a configuration property#422
Open
lars-sh wants to merge 57 commits into
Open
Allow ignoring specific files using a configuration property#422lars-sh wants to merge 57 commits into
lars-sh wants to merge 57 commits into
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
[stable6.0] fix: exclude groupfolder trash and version files
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
The oci8 PHP package does not support PHP 8.4 yet. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
[stable6.0] Fix CI on master
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
[stable6.0] fix: clean up obsolete etag column
[stable6.0] fix: handle null mount points gracefully
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
[stable6.0] fix: wrap encrypted group folders
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
[stable6.0] fix: handle ClamAV not responding properly
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
[stable6.0] faster loading for SharedStorage
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
[stable6.0] fix: check if groupfolder encryption is enabled before wrapping a jail
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Robin Appelman <robin@icewind.nl>
[stable6.0] feat: block uploads when av scanner is not reachable
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud> [skip ci]
[stable6.0] fix: extract actual path when scanning ocTransferId files
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
[stable6.0] fix: use given limit when retrieving unscanned files
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
chore(release): v6.0.5
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
[stable6.0] fix: handle null path gracefully when building infected activity
Signed-off-by: Robin Appelman <robin@icewind.nl>
[stable6.0] fix: don't try to scan content twice if stream is seeked backwards
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
chore(release): v6.1.0
# Conflicts: # .github/workflows/phpunit-oci.yml # CHANGELOG.md # appinfo/info.xml # lib/AppConfig.php # lib/AppInfo/Application.php # lib/AvirWrapper.php # tests/AvirWrapperTest.php
# Conflicts: # appinfo/info.xml # lib/AppInfo/Application.php # lib/Scanner/ExternalKaspersky.php # lib/Scanner/ScannerBase.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
this Pull Request does not follow any standards as I'm not involved in PHP or Nextcloud development usually.
Though, I was working on a quick-fix to implement some simple way to ignore false-positive findings and it might be interesting for others, too.
This might relate to #88 and #178.
Feel free to copy, rework or modify my changes.
The idea is to introduce a simple config.php property called
antivirus_ignorethat takes either an array of full file paths or a string that needs to be a valid regular expression which needs to match the file path using preg_match. If so, the file is ignored and no more warning is reported.You can check this e.g. using occ files_antivirus:scan on the command line but it applies to the background scanner in the same way.