installer: database section now visible if auto-setup is used

[scubamuc]

Hey team,

the Nextcloud snap team are busy testing Nextcloud snap PR for vs. 32.0.1snap1 and have come across an (issue/change) during initial setup which we're confused about...

nextcloud-snap/nextcloud-snap#3305 (comment)

nextcloud (beta/pr-3305) 0+git.493ed6a from Nextcloud✓ installed

Initial setup

• initial install page shows selector for storage and DB

do you know if there's any method to disable the initial install selector? since autoconfig is detected and in place, we should be able to skip that?

any ideas?

[szaimen]

cc @kesselb

[kesselb]

The storage and database section button being shown is related to the migration of the setup page to vue: #51464.

stable31 hides the button if datadirectory and database are given and errors beeing empty:

server/core/templates/installation.php

Lines 59 to 63 in a45e1f1

	<?php if (!$_['directoryIsSet'] or !$_['dbIsSet'] or count($_['errors']) > 0): ?>
	<fieldset id="advancedHeader">
	<legend><a id="showAdvanced" tabindex="0" href="#"><?php p($l->t('Storage & database')); ?><img src="<?php print_unescaped(image_path('core', 'actions/caret.svg')); ?>" /></a></legend>
	</fieldset>
	<?php endif; ?>

stable32 always shows the button, the section is closed when the configuration is valid:

server/core/src/views/Setup.vue

Lines 69 to 70 in 9581230

	<details :open="!isValidAutoconfig" data-cy-setup-form-advanced-config>
	<summary>{{ t('core', 'Storage & database') }}</summary>

do you know if there's any method to disable the initial install selector?

There's none.

cc @skjnldsv @susnux

[kesselb]

0. Needs triage (Pending check for reproducibility or if it fits our roadmap)

Is reproduciable.

Needs decision if it fits the roadmap or we are good with the button always beeing shown.

[scubamuc]

0. Needs triage (Pending check for reproducibility or if it fits our roadmap)

Reproduciable.

Needs decision if it fits the roadmap or we are good with the button always beeing shown.

please don't hesitate to give me a shout if you need a testing instance, although its easy to install and remove using snap;

• install

sudo snap install nextcloud --channel=latest/beta/pr-3305

• remove

sudo snap remove --purge nextcloud

[susnux]

I think it behaves like I would expect it to behave:

• if no auto config it expands the section to fill in data
• if auto config is used it pre-fills the form but allows to manually change if needed (but collapses section by default)

I think this is more a discussion for product design, cc @nextcloud/designers