From 71aa36860fe1390562d98226c5b80a58bcb139b2 Mon Sep 17 00:00:00 2001 From: Benjamin Gaussorgues Date: Fri, 3 Apr 2026 17:00:01 +0200 Subject: [PATCH 1/2] chore(tests): check Snowflake ID preserved in 32 bits Signed-off-by: Benjamin Gaussorgues --- tests/lib/Preview/PreviewMapperTest.php | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/lib/Preview/PreviewMapperTest.php b/tests/lib/Preview/PreviewMapperTest.php index b4a392b78f9f5..96f68ddf9eee9 100644 --- a/tests/lib/Preview/PreviewMapperTest.php +++ b/tests/lib/Preview/PreviewMapperTest.php @@ -64,7 +64,7 @@ public function testGetAvailablePreviews(): void { $this->assertEquals('default', $previews[43][0]->getObjectStoreName()); } - private function createPreviewForFileId(int $fileId, ?int $bucket = null): void { + private function createPreviewForFileId(int $fileId, ?int $bucket = null): string { $locationId = null; if ($bucket) { $qb = $this->connection->getQueryBuilder(); @@ -95,5 +95,16 @@ private function createPreviewForFileId(int $fileId, ?int $bucket = null): void $preview->setLocationId($locationId); } $this->previewMapper->insert($preview); + + return $preview->id; + } + + public function testLargeIdInsertRetrieve(): void { + $fileId = PHP_INT_MAX; + $originalPreviewId = $this->createPreviewForFileId($fileId); + + $dbPreview = $this->previewMapper->getAvailablePreviews([$fileId])[$fileId][0]; + $this->assertEquals($originalPreviewId, $dbPreview->id); + $this->assertEquals($fileId, $dbPreview->getFileId()); } } From 1b241388eeb74789113030790e07f0dcaf9866e6 Mon Sep 17 00:00:00 2001 From: Benjamin Gaussorgues Date: Fri, 3 Apr 2026 17:01:47 +0200 Subject: [PATCH 2/2] chore(tests): run 32 bits tests when PreviewMapper test change Signed-off-by: Benjamin Gaussorgues --- .github/workflows/phpunit-32bits.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/phpunit-32bits.yml b/.github/workflows/phpunit-32bits.yml index 85982e1ede354..fb6aa7bd4b474 100644 --- a/.github/workflows/phpunit-32bits.yml +++ b/.github/workflows/phpunit-32bits.yml @@ -9,6 +9,7 @@ on: - ".github/workflows/phpunit-32bits.yml" - "tests/phpunit-autotest.xml" - "lib/private/Snowflake/*" + - "tests/lib/Preview/PreviewMapperTest.php" workflow_dispatch: schedule: - cron: "15 1 * * 1-6"