Skip to content

Commit 19a382f

Browse files
committed
fix Error: FORWARD_NULL (CWE-476): [#def23]
Fix the following errors found by covscan, Error: FORWARD_NULL (CWE-476): [#def23] python-dmidecode-3.12.2/src/dmilog.c:48: var_compare_op: Comparing "ret" to null implies that "ret" might be null. python-dmidecode-3.12.2/src/dmilog.c:51: var_deref_op: Dereferencing null pointer "ret". # 49| fprintf(stderr, "** ERROR ** Could not allocate memory for log data\n"); # 50| } # 51|-> ret->level = -1; // Initialised - chain header pointer always have -1. # 52| return ret; # 53| } Error: CLANG_WARNING: [#def24] python-dmidecode-3.12.2/src/dmilog.c:51:13: warning[core.NullDereference]: Access to field 'level' results in a dereference of a null pointer (loaded from variable 'ret') # 49| fprintf(stderr, "** ERROR ** Could not allocate memory for log data\n"); # 50| } # 51|-> ret->level = -1; // Initialised - chain header pointer always have -1. # 52| return ret; # 53| } Error: GCC_ANALYZER_WARNING (CWE-476): [#def25] python-dmidecode-3.12.2/src/dmilog.c: scope_hint: In function 'log_init' python-dmidecode-3.12.2/src/dmilog.c:51:20: warning[-Wanalyzer-null-dereference]: dereference of NULL 'ret' # 49| fprintf(stderr, "** ERROR ** Could not allocate memory for log data\n"); # 50| } # 51|-> ret->level = -1; // Initialised - chain header pointer always have -1. # 52| return ret; # 53| } Error: GCC_ANALYZER_WARNING (CWE-476): [#def26] python-dmidecode-3.12.2/src/dmilog.c: scope_hint: In function ���log_init��� python-dmidecode-3.12.2/src/dmilog.c:51:20: warning[-Wanalyzer-null-dereference]: dereference of NULL ���ret��� # 49| fprintf(stderr, "** ERROR ** Could not allocate memory for log data\n"); # 50| } # 51|-> ret->level = -1; // Initialised - chain header pointer always have -1. # 52| return ret; # 53| }
1 parent 17e01f3 commit 19a382f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/dmilog.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ Log_t * log_init()
4747
ret = (Log_t *) calloc(1, sizeof(Log_t)+2);
4848
if( !ret ) {
4949
fprintf(stderr, "** ERROR ** Could not allocate memory for log data\n");
50+
return ret;
5051
}
5152
ret->level = -1; // Initialised - chain header pointer always have -1.
5253
return ret;

0 commit comments

Comments
 (0)