P2: Untangle dependency-cruiser architecture boundary findings

[njrini99-code]

Generated by PR #358 architecture radar.

Finding group:

• Scanner: dependency-cruiser
• Count: 26 violations
• Rules:
  • lib-must-not-import-app: 18
  • coachhelm-core-must-not-import-ui-pages: 6
  • no-circular-coachhelm-or-stats: 2

Local report:

• docs/operations/generated/dependency-cruiser.json

Required remediation:

• Move shared app action types/constants out of src/app into src/lib or src/contracts where appropriate.
• Break CoachHelm/theme and golf SG cycles.
• Keep dependency-cruiser advisory until intentional exceptions are documented or violations are fixed.

[njrini99-code]

Still open after PR #358 fixes. Auditor now reports this as an advisory architecture bucket: dependency-cruiser has 26 violations (18 lib-must-not-import-app, 6 coachhelm-core-must-not-import-ui-pages, 2 CoachHelm/Golf cycles). This is real refactor work and should not be mixed into the production-readiness wiring PR.

[njrini99-code]

Resolved: dependency-cruiser errors 25 → 0 (npm run analyze:deps). Moved shared types to src/lib (decision-room, golf stats/offline), push token via /api/golf/device-token, integration test to src/test/baseball/. Commit 5a6cc85.