BaseballHelm: Persist and surface requires_rsvp for baseball calendar events

[njrini99-code]

Problem

Baseball calendar hardcodes requires_rsvp: false on read, and createBaseballEvent never writes requires_rsvp even when the shared calendar UI sends requiresRsvp. Player RSVP controls in EventDetailModal/MobileEventSheet are gated on event.requires_rsvp, so RSVP is effectively dead for BaseballHelm.

Evidence

• src/app/baseball/(dashboard)/dashboard/calendar/page.tsx line 107: requires_rsvp: false
• src/app/baseball/actions/calendar.ts insert (lines 132-147): omits requires_rsvp; RSVP attendance is only created when input.requiresRsvp (line 153)
• scripts/seed-baseball-demo.ts / team-ops seeds show the column exists on baseball_events

Why it matters

Coaches cannot run mandatory RSVPs for practices/games; players never see RSVP buttons despite coach intent.

Acceptance criteria

• Create/update actions persist requires_rsvp (and existing deadline/max fields).
• Calendar page maps the DB value into CalendarEvent.
• Coach-created RSVP-required event shows player RSVP UI; non-RSVP events do not.

[coderabbitai]

🔗 Related PRs

#25 - fix(migration): make 037_baseball_missing_tables replay-safe [closed]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[njrini99-code]

@coderabbitai plan

[coderabbitai]

Coding Plan

Summary

• Add the missing requires_rsvp column to baseball_events via migration (the ticket's premise that it already exists is incorrect) and align the generated DB types.
• Persist input.requiresRsvp in both createBaseballEvent (insert) and updateBaseballEvent (conditional update), exactly mirroring the existing golf reference pattern; field casing already matches end-to-end so no payload transformation is needed.
• Read and map requires_rsvp on the baseball calendar page instead of hardcoding false, which makes MobileEventSheet's player RSVP controls (gated directly on event.requires_rsvp) show for RSVP-required events and hide otherwise.
• Intentionally leave BASEBALL_CALENDAR_CAPABILITIES.rsvpRead as false, since the shared RSVP-summary read path is hardcoded to golf tables; enabling the desktop modal's read-side RSVP sections is a separate, larger refactor out of scope here.

Design Choices

Design Choice 1: How should the desktop `EventDetailModal` player RSVP UI be surfaced, given it is gated on `capabilities.rsvpRead` which baseball keeps `false`?

Options Considered:

1. Keep rsvpRead: false. Persistence + mapping makes event.requires_rsvp truthful, so MobileEventSheet (which gates player RSVP buttons directly on event.requires_rsvp, independent of rsvpRead) shows/hides RSVP UI correctly. Desktop modal player RSVP card and coach RSVP-status section remain hidden for baseball.
2. Flip rsvpRead: true. Enables desktop modal RSVP sections, but causes the golf-hardcoded summary fetch to query golf_event_attendance for baseball event IDs — returning empty/garbage or unrelated data.
3. Introduce a sport-agnostic getRsvpSummary handler on CalendarActionHandlers, route PremiumCalendarClient/EventDetailModal reads through it, and implement a baseball version querying baseball_event_attendance, then flip rsvpRead.

Chosen Option: 1

Rationale: Option 1 satisfies the persistence/mapping acceptance criteria and surfaces player RSVP UI via the mobile sheet without breaking the golf read path; Option 3's read-layer refactor is a substantially larger, separable effort and is out of scope for this ticket. The shared RSVP-summary read path (useEventRSVP → getEventRSVP → golf_event_attendance) is hardcoded to golf's tables/vocabulary and is not capability-injectable; BaseballCalendarWrapper deliberately sets rsvpRead: false to prevent the shared UI from querying golf tables with baseball event IDs.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Phase 1: Add the requires_rsvp column and align generated types

This phase closes the root-cause schema gap so the flag has somewhere to live, mirroring the existing golf_events definition.

Task 1: Add a migration adding `requires_rsvp` to `baseball_events`

Create the missing column so the value can be persisted.

• Add a new timestamped migration under supabase/migrations/ that runs ALTER TABLE public.baseball_events ADD COLUMN IF NOT EXISTS requires_rsvp boolean DEFAULT false.
• Match the golf precedent: golf_events.requires_rsvp boolean DEFAULT false (defined in the baseline migration). Default false ensures existing rows are backfilled to a safe, non-RSVP state.
• No data backfill beyond the default is needed; existing events should default to not requiring RSVP.

Task 2: Update generated DB types for `baseball_events`

Keep the typed Supabase client in sync with the new column so the action's insert/update payloads type-check.

• Update src/lib/types/database.ts to add requires_rsvp: boolean | null (and the nullable/optional variants) to the baseball_events Row, Insert, and Update definitions, mirroring how golf_events already declares requires_rsvp.
• No change is needed to the CalendarEvent interface in src/hooks/useCalendarEvents.ts; it already declares requires_rsvp?: boolean.

🤖 Prompt for AI agents

Implement the database schema change that adds the `requires_rsvp` flag to
`baseball_events` and keeps generated TypeScript types in sync.

1. Create a new timestamped migration file under `supabase/migrations/`
containing `ALTER TABLE public.baseball_events ADD COLUMN IF NOT EXISTS
requires_rsvp boolean DEFAULT false`. This mirrors the existing
`golf_events.requires_rsvp boolean DEFAULT false` column from the baseline
migration. Do not add any additional data backfill — the `DEFAULT false` handles
existing rows.

2. Update `src/lib/types/database.ts`: add `requires_rsvp: boolean | null` (with
appropriate nullable/optional variants matching the pattern already used for
`golf_events`) to the `Row`, `Insert`, and `Update` type definitions for
`baseball_events`.

3. Do not modify the `CalendarEvent` interface in
`src/hooks/useCalendarEvents.ts` — it already declares `requires_rsvp?:
boolean`.

Phase 2: Persist on write and surface on read

This phase wires the already-matching camelCase payload through to the new column and stops the read path from hardcoding false, mirroring the golf implementation.

Task 1: Persist `requires_rsvp` in the create action

Ensure a coach-created RSVP-required event stores the flag.

• In src/app/baseball/actions/calendar.ts, update createBaseballEvent's .insert({...}) payload to set requires_rsvp: input.requiresRsvp ?? false, alongside the existing max_attendees/rsvp_deadline fields.
• Leave the existing attendance-seeding logic (baseball_event_attendance pending rows when input.requiresRsvp is true) unchanged.

Task 2: Persist `requires_rsvp` in the update action

Ensure toggling RSVP on/off when editing an event is saved.

• In src/app/baseball/actions/calendar.ts, in updateBaseballEvent's updateData builder, add if (input.requiresRsvp !== undefined) updateData.requires_rsvp = input.requiresRsvp;, matching the existing conditional pattern used for max_attendees/rsvp_deadline.

Task 3: Map the persisted value on the calendar read path

Stop hardcoding false so the shared UI reflects real coach intent.

• In src/app/baseball/(dashboard)/dashboard/calendar/page.tsx, add requires_rsvp to the .select(...) field list for baseball_events.
• Replace the hardcoded requires_rsvp: false (around line 107) with requires_rsvp: event.requires_rsvp ?? false in the DB-row → CalendarEvent mapping, mirroring golf's page mapping.
• getTeamEvents already uses select('*') and will pick up the new column automatically; no change required there.

🤖 Prompt for AI agents

Wire the new `requires_rsvp` column through the baseball calendar write and read
paths, mirroring golf's existing implementation. The camelCase `requiresRsvp`
payload already matches the action input shapes, so no payload transformation is
needed.

1. In `src/app/baseball/actions/calendar.ts`, in `createBaseballEvent`'s
`.insert({...})` call, add `requires_rsvp: input.requiresRsvp ?? false` to the
inserted fields, alongside the existing `max_attendees`/`rsvp_deadline` fields.
Do not change the existing attendance-seeding logic that creates pending
`baseball_event_attendance` rows when `input.requiresRsvp` is true.

2. In the same file, in `updateBaseballEvent`'s `updateData` builder, add a
conditional line: `if (input.requiresRsvp !== undefined)
updateData.requires_rsvp = input.requiresRsvp;`, following the same conditional
pattern already used for `max_attendees` and `rsvp_deadline`.

3. In `src/app/baseball/(dashboard)/dashboard/calendar/page.tsx`:
- Add `requires_rsvp` to the `.select(...)` field list used for fetching
`baseball_events`.
- Replace the hardcoded `requires_rsvp: false` (around line 107) in the DB-row →
`CalendarEvent` mapping with `requires_rsvp: event.requires_rsvp ?? false`,
mirroring how golf's page maps this field.
- Leave `getTeamEvents` unchanged since it already uses `select('*')` and will
automatically include the new column.

Research

The baseball calendar reuses golf's shared calendar UI (PremiumCalendarClient + EventDetailModal/MobileEventSheet) via BaseballCalendarWrapper, which injects baseball server actions (createBaseballEvent, updateBaseballEvent, respondToBaseballEvent). The shared form sends camelCase requiresRsvp/rsvpDeadline/maxAttendees, which already match the camelCase CreateEventInput/UpdateEventInput shapes in src/app/baseball/actions/calendar.ts. The golf side already correctly persists and maps requires_rsvp (with audit-fix comments) and serves as the reference pattern. The gap is isolated to baseball: baseball_events lacks the requires_rsvp column entirely, the create/update actions never write it, and the calendar page hardcodes requires_rsvp: false on read.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

Implement the database schema change that adds the `requires_rsvp` flag to
`baseball_events` and keeps generated TypeScript types in sync.

1. Create a new timestamped migration file under `supabase/migrations/`
containing `ALTER TABLE public.baseball_events ADD COLUMN IF NOT EXISTS
requires_rsvp boolean DEFAULT false`. This mirrors the existing
`golf_events.requires_rsvp boolean DEFAULT false` column from the baseline
migration. Do not add any additional data backfill — the `DEFAULT false` handles
existing rows.

2. Update `src/lib/types/database.ts`: add `requires_rsvp: boolean | null` (with
appropriate nullable/optional variants matching the pattern already used for
`golf_events`) to the `Row`, `Insert`, and `Update` type definitions for
`baseball_events`.

3. Do not modify the `CalendarEvent` interface in
`src/hooks/useCalendarEvents.ts` — it already declares `requires_rsvp?:
boolean`.
===============================================================================

Task: 2

Wire the new `requires_rsvp` column through the baseball calendar write and read
paths, mirroring golf's existing implementation. The camelCase `requiresRsvp`
payload already matches the action input shapes, so no payload transformation is
needed.

1. In `src/app/baseball/actions/calendar.ts`, in `createBaseballEvent`'s
`.insert({...})` call, add `requires_rsvp: input.requiresRsvp ?? false` to the
inserted fields, alongside the existing `max_attendees`/`rsvp_deadline` fields.
Do not change the existing attendance-seeding logic that creates pending
`baseball_event_attendance` rows when `input.requiresRsvp` is true.

2. In the same file, in `updateBaseballEvent`'s `updateData` builder, add a
conditional line: `if (input.requiresRsvp !== undefined)
updateData.requires_rsvp = input.requiresRsvp;`, following the same conditional
pattern already used for `max_attendees` and `rsvp_deadline`.

3. In `src/app/baseball/(dashboard)/dashboard/calendar/page.tsx`:
- Add `requires_rsvp` to the `.select(...)` field list used for fetching
`baseball_events`.
- Replace the hardcoded `requires_rsvp: false` (around line 107) in the DB-row →
`CalendarEvent` mapping with `requires_rsvp: event.requires_rsvp ?? false`,
mirroring how golf's page maps this field.
- Leave `getTeamEvents` unchanged since it already uses `select('*')` and will
automatically include the new column.

💡 Iterate on the plan with: `@coderabbitai` <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!

[njrini99-code]

Fixed and deployed in PR #650 (main 08a94d1) — explicitly named in the PR's fix list. Reopen if it doesn't hold on prod.