Testing SSMSE with recent versions of SS3

[dgoto2]

I'm tring to set up SSMSE for a SS3 model developed with more recent versions of SS3 (>V3.30.22), but SSMSE does not seem to be compatible with these recent versions. When I apply the develop_OMs function, it throws the following error:

Error in run_ss_model(dir = tmp_mod_path, admb_options = "-maxfn 0 -phase 50 -nohess", :
New data file (data.ss_new if using SS3 v3.30.18 or data_echo.ss_new if using SS3 v3.30.21) was not created during the model run, which suggests SS3 did not run correctly.

After swapping SS3 excutables in the package, SS3 seems to read the input files correctly, but it still throws an error because the .par file name in the develop_OMs function seems to be hard-coded.

[k-doering-NOAA]

@dgoto2 thank you for opening an issue about this.

Here is some text from the SSMSE readme explaining which versions of SS3 work with SSMSE:

Note that when SSMSE is installed, Stock Synthesis binaries are included in the SSMSE/bin/ folder downloaded to the user’s local R library. Currently, Stock Synthesis 3.30.18 is included and 3.30.21 has been tested. Separate binaries are included for Windows, Mac and Linux. Users may swap out these binaries, but SSMSE is not tested with all versions of SSMSE.

So, unfortunately, I think the observation that SS3 >v3.30.22 is not compatible is correct, as it has not been tested.

If you would like to update the codebase to work with newer versions and submit a pull request, that would be welcomed and @e-perl-NOAA and @nathanvaughan-NOAA can likely help review the pull request this summer. Alternatively, using SSMSE with SS3 v3.30.18 or v3.30.21 should work - if it does not, please feel free to open an issue or pull request so any bugs can be fixed.

[dgoto2]

Thank you for your quick response @k-doering-NOAA. I'll try to refit the model with SS3 v3.30.21 and set up SSMSE with it first. Most likely minor changes in the input files would be needed. If there is any issue, I'll submit a pull request.