Skip to content

"genericize" import_agepro_inp_model fof all agepro_model classes #102

@efletcherPIFSC

Description

@efletcherPIFSC

AGEPRO Input Files (*.INP) is the the primarily input format format for ageproR, this package introduces JSON format files

import_agepro_inp_model is designed to import data from saved in agepro_inp_model classes to agepro_json_model, which can be written as JSON files. Looking at the function's code, the function is not dependent on the structure of agepro_inp_model and agepro_json_model, this can be refactored to agepro_model.

Simplified Diagram

classDiagram
  class agepro_model {
    - import_agepro_model(model)
  }

  class agepro_inp_model {
    + import_agepro_model(json_model)
  }

  class agepro_json_model {
    +import_agepro_model(inp_model)
  }

agepro_model <|-- agepro_inp_model
agepro_model <|-- agepro_json_model

Loading

Questions

  • How feasible to have a convivence function that will allow users to import agepro_model data to a new instance?
  • What about importing agepro_model to another agepro_model (of the same class)?
  • In addition to adhering to agepro_json_model structure, what JSON validations are needed when importing JSON files.
  • What does changes to the JSON Input Structure (json_version) complicate this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions