From ecbaaec8298fefe16b26c081ed5a5ccdbf6ed71c Mon Sep 17 00:00:00 2001 From: Richard Methot Date: Mon, 4 Aug 2025 15:44:57 -0700 Subject: [PATCH 1/5] add warning for Lmin < len_bin(1) --- SS_readcontrol_330.tpl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/SS_readcontrol_330.tpl b/SS_readcontrol_330.tpl index a8f871a3..aa8aa9be 100644 --- a/SS_readcontrol_330.tpl +++ b/SS_readcontrol_330.tpl @@ -1617,6 +1617,18 @@ mgp_type(Ip, Ip + N_natMparms - 1) = 1; // natmort parms Ip += N_natMparms; mgp_type(Ip, Ip + N_growparms - 1) = 2; // growth parms + + // check on out of bound Lmin values. Only check females because males can be offset from females + if ( gp == 1 && MGparm_1(Ip,1) < len_bins(1)) + { + warnstream << "parm min for Lmin: " << MGparm_1(Ip,1) << " cannot be less than population min length bin " << len_bins(1); + write_message (FATAL, 0); // EXIT! + } + if ( gp == 1 && MGparm_1(Ip,3) < len_bins(1)) + { + warnstream << "parm init value for Lmin: " << MGparm_1(Ip,3) << " cannot be less than population min length bin " << len_bins(1); + write_message (FATAL, 0); // EXIT! + } // check on estimation of variance parameters for CV_young and CV_old for (int kk = Ip + N_growparms - 2; kk <= Ip + N_growparms - 1; kk++) From 29942e9c629878a2e1af7166ef909e67a27828ce Mon Sep 17 00:00:00 2001 From: Richard Methot Date: Mon, 4 Aug 2025 15:55:16 -0700 Subject: [PATCH 2/5] add that WTage_rd must be 0 --- SS_readcontrol_330.tpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SS_readcontrol_330.tpl b/SS_readcontrol_330.tpl index aa8aa9be..b5cf3def 100644 --- a/SS_readcontrol_330.tpl +++ b/SS_readcontrol_330.tpl @@ -1619,12 +1619,12 @@ mgp_type(Ip, Ip + N_growparms - 1) = 2; // growth parms // check on out of bound Lmin values. Only check females because males can be offset from females - if ( gp == 1 && MGparm_1(Ip,1) < len_bins(1)) + if ( gp == 1 && WTage_rd == 0 && MGparm_1(Ip,1) < len_bins(1)) { warnstream << "parm min for Lmin: " << MGparm_1(Ip,1) << " cannot be less than population min length bin " << len_bins(1); write_message (FATAL, 0); // EXIT! } - if ( gp == 1 && MGparm_1(Ip,3) < len_bins(1)) + if ( gp == 1 && WTage_rd == 0 && MGparm_1(Ip,3) < len_bins(1)) { warnstream << "parm init value for Lmin: " << MGparm_1(Ip,3) << " cannot be less than population min length bin " << len_bins(1); write_message (FATAL, 0); // EXIT! From ab83b4f2b01daccebee62ffc3653d91b5d12cde0 Mon Sep 17 00:00:00 2001 From: Elizabeth Perl Date: Tue, 5 Aug 2025 10:25:34 -0400 Subject: [PATCH 3/5] see if run-ss3-no-est will pass with updated test models --- .github/workflows/run-ss3-no-est.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-ss3-no-est.yml b/.github/workflows/run-ss3-no-est.yml index b8d18e54..8e9dd49d 100644 --- a/.github/workflows/run-ss3-no-est.yml +++ b/.github/workflows/run-ss3-no-est.yml @@ -43,6 +43,7 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo + ref: lmin_lenbin_fix - name: Update Ubuntu packages run: | From 2c5e0a2c4a3f42304f8ca7de4091b61dd377cb84 Mon Sep 17 00:00:00 2001 From: Elizabeth Perl Date: Tue, 5 Aug 2025 10:47:12 -0400 Subject: [PATCH 4/5] test rest of actions failing with new branch - will revert to main once test models branch is merged into main in that repo --- .github/workflows/run-ss3-bootstrap.yml | 1 + .github/workflows/run-ss3-mcmc.yml | 1 + .github/workflows/run-ss3-with-est.yml | 1 + .github/workflows/test-r4ss-with-ss3.yml | 1 + 4 files changed, 4 insertions(+) diff --git a/.github/workflows/run-ss3-bootstrap.yml b/.github/workflows/run-ss3-bootstrap.yml index aa1e8910..142714e8 100644 --- a/.github/workflows/run-ss3-bootstrap.yml +++ b/.github/workflows/run-ss3-bootstrap.yml @@ -39,6 +39,7 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo + ref: lmin_lenbin_fix - name: Install libcurl & other necessary packages run: | diff --git a/.github/workflows/run-ss3-mcmc.yml b/.github/workflows/run-ss3-mcmc.yml index 8ec627bf..d9e1b677 100644 --- a/.github/workflows/run-ss3-mcmc.yml +++ b/.github/workflows/run-ss3-mcmc.yml @@ -38,6 +38,7 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo + ref: lmin_lenbin_fix - name: Update Ubuntu packages run: | diff --git a/.github/workflows/run-ss3-with-est.yml b/.github/workflows/run-ss3-with-est.yml index f3611431..f3d40a68 100644 --- a/.github/workflows/run-ss3-with-est.yml +++ b/.github/workflows/run-ss3-with-est.yml @@ -39,6 +39,7 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo + ref: lmin_lenbin_fix - name: Update Ubuntu packages run: | diff --git a/.github/workflows/test-r4ss-with-ss3.yml b/.github/workflows/test-r4ss-with-ss3.yml index e24f4475..53f15856 100644 --- a/.github/workflows/test-r4ss-with-ss3.yml +++ b/.github/workflows/test-r4ss-with-ss3.yml @@ -39,6 +39,7 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo + ref: lmin_lenbin_fix - name: Install libcurl and other necessary linux packages run: | From ae8f4e05c910bca4f69f49b4be01fbd2738bcf0e Mon Sep 17 00:00:00 2001 From: Elizabeth Perl Date: Tue, 5 Aug 2025 16:09:28 -0400 Subject: [PATCH 5/5] go back to using main branch of test models now that it's fixed and passing --- .github/workflows/run-ss3-bootstrap.yml | 1 - .github/workflows/run-ss3-mcmc.yml | 1 - .github/workflows/run-ss3-no-est.yml | 1 - .github/workflows/run-ss3-with-est.yml | 1 - .github/workflows/test-r4ss-with-ss3.yml | 1 - 5 files changed, 5 deletions(-) diff --git a/.github/workflows/run-ss3-bootstrap.yml b/.github/workflows/run-ss3-bootstrap.yml index 142714e8..aa1e8910 100644 --- a/.github/workflows/run-ss3-bootstrap.yml +++ b/.github/workflows/run-ss3-bootstrap.yml @@ -39,7 +39,6 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo - ref: lmin_lenbin_fix - name: Install libcurl & other necessary packages run: | diff --git a/.github/workflows/run-ss3-mcmc.yml b/.github/workflows/run-ss3-mcmc.yml index d9e1b677..8ec627bf 100644 --- a/.github/workflows/run-ss3-mcmc.yml +++ b/.github/workflows/run-ss3-mcmc.yml @@ -38,7 +38,6 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo - ref: lmin_lenbin_fix - name: Update Ubuntu packages run: | diff --git a/.github/workflows/run-ss3-no-est.yml b/.github/workflows/run-ss3-no-est.yml index 8e9dd49d..b8d18e54 100644 --- a/.github/workflows/run-ss3-no-est.yml +++ b/.github/workflows/run-ss3-no-est.yml @@ -43,7 +43,6 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo - ref: lmin_lenbin_fix - name: Update Ubuntu packages run: | diff --git a/.github/workflows/run-ss3-with-est.yml b/.github/workflows/run-ss3-with-est.yml index f3d40a68..f3611431 100644 --- a/.github/workflows/run-ss3-with-est.yml +++ b/.github/workflows/run-ss3-with-est.yml @@ -39,7 +39,6 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo - ref: lmin_lenbin_fix - name: Update Ubuntu packages run: | diff --git a/.github/workflows/test-r4ss-with-ss3.yml b/.github/workflows/test-r4ss-with-ss3.yml index 53f15856..e24f4475 100644 --- a/.github/workflows/test-r4ss-with-ss3.yml +++ b/.github/workflows/test-r4ss-with-ss3.yml @@ -39,7 +39,6 @@ jobs: with: repository: 'nmfs-ost/ss3-test-models' path: test-models-repo - ref: lmin_lenbin_fix - name: Install libcurl and other necessary linux packages run: |