test: add coverage for multiple SSL_CERT_DIR entries

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

Author: Archkon

test/fixtures/tls-check-openssl-ca-certificates.js

@@ -5,9 +5,13 @@ const fs = require('fs');
 const tls = require('tls');
 const { includesCert } = require('../common/tls');
 
-const expected = fs.readFileSync(process.env.SSL_CERT_FILE, 'utf8');
+const expectedCertFiles = process.env.EXPECTED_CERT_FILES ?
+  JSON.parse(process.env.EXPECTED_CERT_FILES) : [process.env.SSL_CERT_FILE];
 const defaultCerts = tls.getCACertificates('default');
 
-assert(includesCert(defaultCerts, expected));
+for (const certFile of expectedCertFiles) {
+  const expected = fs.readFileSync(certFile, 'utf8');
+  assert(includesCert(defaultCerts, expected));
+}
 assert.strictEqual(defaultCerts, tls.getCACertificates());
 assert.strictEqual(defaultCerts, tls.getCACertificates('default'));

test/parallel/test-tls-get-ca-certificates-openssl.js

@@ -1,23 +1,43 @@
 'use strict';
 
 // This tests that tls.getCACertificates('default') includes certificates from
-// OpenSSL's default certificate file when --use-openssl-ca is enabled.
+// OpenSSL's default certificate file and directories when --use-openssl-ca is
+// enabled.
 
 const common = require('../common');
 if (!common.hasCrypto) common.skip('missing crypto');
 
+const fs = require('fs');
+const path = require('path');
 const { spawnSyncAndExitWithoutError } = require('../common/child_process');
 const fixtures = require('../common/fixtures');
+const tmpdir = require('../common/tmpdir');
+
+tmpdir.refresh();
+
+const firstCertDir = tmpdir.resolve('openssl-certs-1');
+const secondCertDir = tmpdir.resolve('openssl-certs-2');
+fs.mkdirSync(firstCertDir);
+fs.mkdirSync(secondCertDir);
+
+const expectedCertFiles = [
+  fixtures.path('keys', 'ca1-cert.pem'),
+  fixtures.path('keys', 'ca2-cert.pem'),
+  fixtures.path('keys', 'ca3-cert.pem'),
+];
+fs.copyFileSync(expectedCertFiles[1], path.join(firstCertDir, 'ca2-cert.pem'));
+fs.copyFileSync(expectedCertFiles[2], path.join(secondCertDir, 'ca3-cert.pem'));
 
 spawnSyncAndExitWithoutError(
   process.execPath,
   ['--use-openssl-ca', fixtures.path('tls-check-openssl-ca-certificates.js')],
   {
     env: {
       ...process.env,
+      EXPECTED_CERT_FILES: JSON.stringify(expectedCertFiles),
       NODE_EXTRA_CA_CERTS: undefined,
-      SSL_CERT_FILE: fixtures.path('keys', 'ca1-cert.pem'),
-      SSL_CERT_DIR: '',
+      SSL_CERT_FILE: expectedCertFiles[0],
+      SSL_CERT_DIR: [firstCertDir, secondCertDir].join(path.delimiter),
     },
   },
 );