Skip to content

Commit 2cc4c81

Browse files
committed
Revert "test: reduce flakiness of different-registry-per-thread"
This reverts commit 130398a. PR-URL: #63244 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent b06aee0 commit 2cc4c81

2 files changed

Lines changed: 4 additions & 17 deletions

File tree

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,15 @@
11
import { isMainThread, Worker } from 'node:worker_threads';
22

3-
const registeredRefs = [];
4-
5-
const ref = { foo: 'foo' };
6-
registeredRefs.push(ref);
7-
83
if (isMainThread) {
9-
process.finalization.register(ref, () => {
4+
process.finalization.register({ foo: 'foo' }, () => {
105
process.stdout.write('shutdown on main thread\n');
116
});
127

138
const worker = new Worker(import.meta.filename);
149

15-
worker.on('error', (err) => {
16-
// Referencing `registeredRefs` here to avoid `ref` being GCed before the worker exits.
17-
console.log(registeredRefs);
18-
throw err;
19-
});
20-
2110
worker.postMessage('ping');
2211
} else {
23-
process.finalization.register(ref, () => {
12+
process.finalization.register({ foo: 'bar' }, () => {
2413
process.stdout.write('shutdown on worker\n');
2514
});
2615
}

test/parallel/test-memory-usage.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ if (r.arrayBuffers > 0) {
4444
const after = process.memoryUsage();
4545
assert.ok(after.external - r.external >= size,
4646
`${after.external} - ${r.external} >= ${size}`);
47-
// `arrayBuffers` is process-wide, so unrelated backing stores may be freed
48-
// between the two snapshots. Check that the live ArrayBuffer is included.
49-
assert.ok(after.arrayBuffers >= size,
50-
`${after.arrayBuffers} >= ${size}`);
47+
assert.strictEqual(after.arrayBuffers - r.arrayBuffers, size,
48+
`${after.arrayBuffers} - ${r.arrayBuffers} === ${size}`);
5149
}

0 commit comments

Comments
 (0)