src: avoid V8 worker hang during platform shutdown

Author: Archkon

src/node_platform.cc

@@ -526,6 +526,11 @@ void NodePlatform::AddIsolateFinishedCallback(Isolate* isolate,
 void NodePlatform::Shutdown() {
   if (has_shut_down_) return;
   has_shut_down_ = true;
+
+  // V8 background tasks may be parked waiting for foreground GC work before
+  // they can return from the worker thread task.
+  while (FlushForegroundTasksForAllIsolates()) {}
+
   worker_thread_task_runner_->Shutdown();
 
   {
@@ -717,6 +722,25 @@ bool NodePlatform::FlushForegroundTasks(Isolate* isolate) {
   return per_isolate->FlushForegroundTasksInternal();
 }
 
+bool NodePlatform::FlushForegroundTasksForAllIsolates() {
+  std::vector<std::shared_ptr<PerIsolatePlatformData>> per_isolates;
+  {
+    Mutex::ScopedLock lock(per_isolate_mutex_);
+    per_isolates.reserve(per_isolate_.size());
+    for (const auto& entry : per_isolate_) {
+      if (entry.second.second) {
+        per_isolates.push_back(entry.second.second);
+      }
+    }
+  }
+
+  bool did_work = false;
+  for (const auto& per_isolate : per_isolates) {
+    did_work |= per_isolate->FlushForegroundTasksInternal();
+  }
+  return did_work;
+}
+
 std::unique_ptr<v8::JobHandle> NodePlatform::CreateJobImpl(
     v8::TaskPriority priority,
     std::unique_ptr<v8::JobTask> job_task,

src/node_platform.h

@@ -266,6 +266,7 @@ class NodePlatform : public MultiIsolatePlatform {
  private:
   IsolatePlatformDelegate* ForIsolate(v8::Isolate* isolate);
   std::shared_ptr<PerIsolatePlatformData> ForNodeIsolate(v8::Isolate* isolate);
+  bool FlushForegroundTasksForAllIsolates();
 
   Mutex per_isolate_mutex_;
   using DelegatePair = std::pair<IsolatePlatformDelegate*,