inspector: tighten createInitiator coverage

Author: GrinZero

src/inspector/network_agent.cc

@@ -86,10 +86,13 @@ static std::unique_ptr<protocol::Value> V8ToProtocolValue(
     std::unique_ptr<protocol::DictionaryValue> dict =
         protocol::DictionaryValue::create();
     for (uint32_t i = 0; i < property_names->Length(); i++) {
-      Local<Value> key;
+      // `property_names` is a JSArray returned from GetOwnPropertyNames, so
+      // indexed access always succeeds. User-defined getters can still throw
+      // when reading the property value, which is what we guard against.
+      Local<Value> key =
+          property_names->Get(context, i).ToLocalChecked();
       Local<Value> property;
-      if (!property_names->Get(context, i).ToLocal(&key) ||
-          !GetProperty(context, object, key).ToLocal(&property)) {
+      if (!GetProperty(context, object, key).ToLocal(&property)) {
         return nullptr;
       }
       std::unique_ptr<protocol::Value> protocol_value =

test/parallel/test-inspector-emit-protocol-event.js

@@ -195,8 +195,8 @@ for (const [domain, events] of Object.entries(EXPECTED_EVENTS)) {
   }
 
   // Verify a user-supplied initiator (with stack) is preserved end-to-end.
-  // Covers the success body of `if (ObjectGetObject(... "stack"))` in
-  // NetworkAgent::createInitiatorFromObject (network_agent.cc L159).
+  // Covers the true branch of `if (ObjectGetObject(... "stack"))` in
+  // NetworkAgent::createInitiatorFromObject.
   session.removeAllListeners('Network.requestWillBeSent');
   const userInitiator = {
     type: 'script',
@@ -221,8 +221,34 @@ for (const [domain, events] of Object.entries(EXPECTED_EVENTS)) {
     initiator: userInitiator,
   });
 
+  // Verify a user-supplied initiator without `stack` is forwarded as-is.
+  // Covers the false branch of `if (ObjectGetObject(... "stack"))` in
+  // NetworkAgent::createInitiatorFromObject.
+  session.removeAllListeners('Network.requestWillBeSent');
+  const initiatorWithoutStack = {
+    type: 'script',
+    url: 'https://nodejs.org/no-stack.js',
+    lineNumber: 7,
+    columnNumber: 8,
+  };
+  session.on('Network.requestWillBeSent', common.mustCall(({ params }) => {
+    assert.strictEqual(params.requestId, 'request-without-initiator-stack');
+    assert.deepStrictEqual(params.initiator, initiatorWithoutStack);
+  }));
+  inspector.Network.requestWillBeSent({
+    requestId: 'request-without-initiator-stack',
+    request: {
+      url: 'https://nodejs.org/en',
+      method: 'GET',
+      headers: {},
+    },
+    timestamp: 1000,
+    wallTime: 1000,
+    initiator: initiatorWithoutStack,
+  });
+
   // Verify a duplicate requestId is silently ignored. Covers the early
-  // return when `requests_.contains(request_id)` (network_agent.cc L610).
+  // return when `requests_.contains(request_id)` in NetworkAgent::requestWillBeSent.
   session.removeAllListeners('Network.requestWillBeSent');
   const duplicateId = 'duplicate-request-id';
   const duplicateParams = {