From review: internalize QUIC error strings

Signed-off-by: Tim Perry <pimterry@gmail.com>

Author: pimterry

src/quic/data.cc

@@ -23,7 +23,9 @@ using v8::Just;
 using v8::Local;
 using v8::Maybe;
 using v8::MaybeLocal;
+using v8::NewStringType;
 using v8::Nothing;
+using v8::String;
 using v8::Uint8Array;
 using v8::Undefined;
 using v8::Value;
@@ -442,7 +444,8 @@ MaybeLocal<Value> QuicError::ToV8Value(Environment* env) const {
   // names and OpenSSL TLS alert descriptions for CRYPTO_ERROR). Unknown
   // codes leave the slot as undefined.
   if (const char* n = name()) {
-    if (!node::ToV8Value(env->context(), n).ToLocal(&argv[3])) {
+    if (!String::NewFromUtf8(env->isolate(), n, NewStringType::kInternalized)
+             .ToLocal(&argv[3])) {
       return {};
     }
   }

src/quic/session.cc

@@ -49,6 +49,7 @@ using v8::Local;
 using v8::LocalVector;
 using v8::Maybe;
 using v8::MaybeLocal;
+using v8::NewStringType;
 using v8::Nothing;
 using v8::Number;
 using v8::Object;
@@ -3164,7 +3165,8 @@ void Session::EmitClose(const QuicError& error) {
   // codes leave the slot as undefined. See QuicError::name() for the
   // matching path on stream-level errors.
   if (const char* n = error.name()) {
-    if (!ToV8Value(env()->context(), n).ToLocal(&argv[3])) {
+    if (!String::NewFromUtf8(env()->isolate(), n, NewStringType::kInternalized)
+             .ToLocal(&argv[3])) {
       return;
     }
   }