http: only internalize short header field names

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

Author: araujogui

src/node_http_common.h

@@ -16,6 +16,8 @@ class Environment;
 #define DEFAULT_MAX_HEADER_LIST_PAIRS 128u
 #define DEFAULT_MAX_HEADER_LENGTH 8192
 
+constexpr size_t kMaxInternalizedHeaderNameLength = 64;
+
 #define HTTP_SPECIAL_HEADERS(V)                                               \
   V(STATUS, ":status")                                                        \
   V(METHOD, ":method")                                                        \
@@ -432,7 +434,7 @@ class NgRcBufPointer : public MemoryRetainer {
         return v8::String::Empty(env->isolate());
       }
 
-      if (ptr.IsInternalizable() && len < 64) {
+      if (ptr.IsInternalizable() && len < kMaxInternalizedHeaderNameLength) {
         v8::MaybeLocal<v8::String> ret = GetInternalizedString(env, ptr);
         ptr.reset();
         return ret;

src/node_http_parser.cc

@@ -28,6 +28,7 @@
 #include "llhttp.h"
 #include "memory_tracker-inl.h"
 #include "node_external_reference.h"
+#include "node_http_common.h"
 #include "stream_base-inl.h"
 #include "v8.h"
 
@@ -235,14 +236,15 @@ struct StringPtr {
   }
 
   Local<String> ToInternalizedString(Environment* env) const {
-    if (size_ != 0) {
+    // Only internalize short names to avoid pressuring the string table.
+    if (size_ != 0 && size_ < kMaxInternalizedHeaderNameLength) {
       return String::NewFromOneByte(env->isolate(),
                                     reinterpret_cast<const uint8_t*>(str_),
                                     NewStringType::kInternalized,
                                     size_)
           .ToLocalChecked();
     }
-    return String::Empty(env->isolate());
+    return ToString(env);
   }
 
   // Strip trailing OWS (SPC or HTAB) from string.