From f0ae4a6ff743dabaa3e8b687aa91fdf1c4966f66 Mon Sep 17 00:00:00 2001 From: Brady Goldsworthy <34688945+brady-goldsworthy@users.noreply.github.com> Date: Tue, 14 Sep 2021 10:01:24 -0600 Subject: [PATCH 1/2] Add preference check for opening existing output tab --- build.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/build.js b/build.js index facb580..c2a3ebf 100644 --- a/build.js +++ b/build.js @@ -61,7 +61,10 @@ Builder = Object.assign(Builder, { if (Builder.Preferences.reuseTab == true) { document.querySelectorAll(".chrome-tab").forEach((e) => { if (e.gmlFile.output != undefined || e.gmlFile.output == true) { - $gmedit["ui.ChromeTabs"].impl.setCurrentTab(e); + //Check for Preference of opening existing tab on compile + if (Builder.Preferences.openOutputTabOnCompile == true) { + $gmedit["ui.ChromeTabs"].impl.setCurrentTab(e); + } e.childNodes.forEach((e) => { if (e.className == "chrome-tab-title") e.innerText = `Output (${Builder.GetTime(Time)})`; }) e.gmlFile.editor.session.setValue(""); Builder.Output = e.gmlFile; @@ -78,7 +81,10 @@ Builder = Object.assign(Builder, { if (aceEditor.session.gmlFile == this) { aceEditor.gotoLine(aceEditor.session.getLength()); } + } + + //If creating new output tab, always open it GmlFile.openTab(Builder.Output); } Builder.Output.editor.session.setValue(`Compile Started: ${Builder.GetTime(Time)}\nUsing Runtime: ${Builder.Preferences.runtimeSelection}`); From 7a52ef90a9547fa663524b7ce3c0070db6186380 Mon Sep 17 00:00:00 2001 From: Brady Goldsworthy <34688945+brady-goldsworthy@users.noreply.github.com> Date: Tue, 14 Sep 2021 10:02:01 -0600 Subject: [PATCH 2/2] Add preference for opening existing output tab on compile --- main.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/main.js b/main.js index 36df087..db310c9 100644 --- a/main.js +++ b/main.js @@ -8,6 +8,7 @@ Builder = { PreferencesElement: document.createElement("div"), Preferences: { reuseTab: false, + openOutputTabOnCompile: true, saveCompile: false, stopCompile: false, displayLine: true, @@ -226,6 +227,7 @@ Builder = { } Preferences.addInput(settingsGroup, "Fork Arguments", Builder.Preferences.forkArguments, (value) => { Builder.Preferences.forkArguments = value; Builder.SavePreferences(); }); Preferences.addCheckbox(settingsGroup, "Reuse Output Tab", Builder.Preferences.reuseTab, (value) => { Builder.Preferences.reuseTab = value; Builder.SavePreferences(); }); + Preferences.addCheckbox(settingsGroup, "Open Existing Output Tab on Compile", Builder.Preferences.openOutputTabOnCompile, (value) => { Builder.Preferences.openOutputTabOnCompile = value; Builder.SavePreferences(); }); Preferences.addCheckbox(settingsGroup, "Save Upon Compile", Builder.Preferences.saveCompile, (value) => { Builder.Preferences.saveCompile = value; Builder.SavePreferences(); }); Preferences.addCheckbox(settingsGroup, "Stop Upon Compile", Builder.Preferences.stopCompile, (value) => { Builder.Preferences.stopCompile = value; Builder.SavePreferences(); }); Preferences.addCheckbox(settingsGroup, "Display Line After Fatal Error", Builder.Preferences.displayLine, (value) => { Builder.Preferences.displayLine = value; Builder.SavePreferences(); });