[Cheng-Zhiyuan] iP by Cheng-Zhiyuan · Pull Request #176 · nus-cs2113-AY2425S2/ip

Cheng-Zhiyuan · 2025-02-06T01:39:53Z

Added Level-0, Level-1, Level-2 and Level-3 commits with respective tags.

…ck when requested.

Add method to mark task as not done

This reverts commit bee16af.

venicephua

Overall very clear and easy to read!

venicephua · 2025-02-07T05:31:56Z

+
+    protected String dateRange;
+
+    public Event(String description, String dateRange, String to) {


can remove unused parameter "to"?

venicephua · 2025-02-07T05:42:14Z

+        while (true) {
+            userInput = ui.readInput();
+            // exit condition
+            if (userInput.equals("bye")) {


perhaps can consider using switch-case instead of if-else since there are quite a few if-else statements?

venicephua · 2025-02-07T05:43:09Z

+        TaskManager taskManager = new TaskManager();
+        UserInterface ui = new UserInterface();
+
+        // Print Greeting.


perhaps can remove these comments as it is rather intuitive from the variable names/functions?

venicephua · 2025-02-07T05:49:00Z

+    }
+
+    public static void printMarkAsDone(Task task) {
+        System.out.printf(INDENT + "Nice! I've marked this task as done:%n", "");


perhaps can define these messages as constants to make the code cleaner?

JinbaoAlex

Keep up the good work!

JinbaoAlex · 2025-02-07T06:59:08Z

@@ -0,0 +1,27 @@
+// For Task commands
+public class TaskManager {
+    public static final int MAX_TASKS = 100;


good work naming constants in all caps

JinbaoAlex · 2025-02-07T07:01:36Z

+    public static final String MARKED_BOX = "[X]";
+
+    protected String description;
+    protected boolean isDone;


correct naming of booleans

JinbaoAlex · 2025-02-07T07:01:41Z

+        this.isDone = false;
+    }
+
+    public void markAsDone() {


good job in using camel case for methods

JinbaoAlex · 2025-02-07T07:03:00Z

+        super(description);
+    }
+
+    @Override


good practice to specify overrides

JinbaoAlex · 2025-02-07T07:05:56Z

@@ -0,0 +1,51 @@
+import java.util.Scanner;


like the proper way to do imports

This reverts commit 965019d.

This reverts commit 19b5c20.

thomasjlalba

Great work so far on your iP! Just minor nitpicks on the code quality and standards that I have suggested

thomasjlalba · 2025-02-20T12:06:58Z

+
+public class Thoth {
+
+    public static void main(String[] args) {


I quite like how you have done quite a bit of abstraction to simpler methods throughout your repo!

thomasjlalba · 2025-02-20T12:08:32Z

+                int taskIndex = Integer.parseInt(userInput.replace("mark", "").trim()) - 1;
+                return new MarkCommand(taskIndex);
+            } catch (NumberFormatException e) {
+                return new UnknownCommand("Please enter a valid number for mark command.");


Maybe you can try to avoid magic literals

thomasjlalba · 2025-02-20T12:10:50Z

+                if (timeParts.length > 1) {
+                    to = timeParts[1].trim(); // Extracts "4pm"
+                }
+            }


Maybe you can add a final else statement to catch any unwanted errors

thomasjlalba · 2025-02-20T12:15:37Z

+    public static Command parse(String userInput) {
+        userInput = userInput.trim();
+
+        if (userInput.equals("bye")) {


Small nitpick but maybe you can standardise the spacing between the if/else statements if(statement){ vs if (statement) {

Noted I will make changes. Thank you~

Remove magic literals

Update Parser Class with FindCommand

Add in javadoc headers

Fix bug for out of bound task index

Cheng-Zhiyuan added 23 commits January 30, 2025 11:44

Rename Duke to Thoth

4af94dc

Add greet and exit

ac9118b

Improve Thoth to echo command and exit when user input bye

f516682

Add the ability to store text entered by the user and display them ba…

1b3cf44

…ck when requested.

Add the ability to mark tasks status as done and revert the status

5b73d7d

Add a Task class to reperesent tasks

b0187dc

Integrate Task class with Thoto class

41bc78c

Integrate Task class with Thoth class

9eaa586

Merge branch 'master' of https://github.com/Cheng-Zhiyuan/ip

c855ac5

Add taskManager class to refactor main code

c0e7679

Add UserInterface class to refactor code

b87b63b

Update Getter function to get task description

c6821dc

Add getter funtion to get task Description

d6a64d9

Add getter function to get tasklist, taskcount

04602e6

Add method to mark task as not done

Refactor code with userinterface class and taskmanager class

b10d512

Add in Todo, Deadline and Event class for week 4

082dc2c

Add in Dealine, Todo and Event Class for week 4

3024348

Add in mthod to print added tasks

bee16af

Update the overide to correctly overrides the correct parent method

e73ef0e

Add method to print added tasks

ccf30e7

Revert "Add in mthod to print added tasks"

ea9d7af

This reverts commit bee16af.

Integrate Todo, Deadline and Event Class with Thoth

73f6bd3

Clean up code formats

dc2ded1

venicephua reviewed Feb 7, 2025

View reviewed changes

JinbaoAlex reviewed Feb 7, 2025

View reviewed changes

Cheng-Zhiyuan added 5 commits February 7, 2025 15:43

COrrect wrong method used in event

965019d

Revert "COrrect wrong method used in event"

19b5c20

This reverts commit 965019d.

Reapply "COrrect wrong method used in event"

8515036

This reverts commit 19b5c20.

Add in excpetion for mark and unmark

f23118b

Add in condition checks for dealine, event and todo

59a61c8

thomasjlalba reviewed Feb 20, 2025

View reviewed changes

Cheng-Zhiyuan and others added 29 commits February 21, 2025 15:43

Build JAR file

4b70796

Change file path to absolute path

754d130

Input data

8ec2349

Formate code to follow correct spacing

d05461c

Add final else statment to catch unwated errors

ce91da0

Remove magic literals

Add FindCommand class

618ce95

Update Parser Class with FindCommand

Update Absolute path to relative path

370cc3f

Remove unused import

f82483d

Add javadoc comments

fd0b686

Update readme with basic user guide

237178f

Delete unused imports

923ec07

Fixed bux of printing wrong user output

582659f

Update Readme

3c1e59e

Update Readme with descriptions

b814be2

Fixed Grammer error

cfb6e70

Update data files

181fc0e

Add in javadoc headers

b7f39a1

Merge pull request #1 from Cheng-Zhiyuan/branch-A-JavaDoc

b4fbbda

Add in javadoc headers

Fix bug for out of bound task index

b5abe09

Merge pull request #2 from Cheng-Zhiyuan/branch_Level_9

794b36d

Fix bug for out of bound task index

update gitignore file

e328d1d

Fix out of bound task index bug

cc0974d

Restructure code from packages to reduce redundency

ff3d1b7

Add in Task Parser to load txt to tasks

58b644d

Refactor parser class

2182a76

Add in Exceptions class

163f214

Add in exception for storage to task parsing

cdec039

update exceptions and cath

0fe8a0d

Reformat code

33efbac


		protected String dateRange;

		public Event(String description, String dateRange, String to) {


		public class Thoth {

		public static void main(String[] args) {

Conversation

Cheng-Zhiyuan commented Feb 6, 2025

Uh oh!

venicephua left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JinbaoAlex left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thomasjlalba left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants