Conversation
Merge pull request #778 from nzbgetcom/develop
- Fix LogFileValidator: check directory for wlReset mode (file gets deleted on startup) - Fix AnyPrimaryServerExistsValidator: check if any lowest level server is active - Fix DownloadRateValidator: change to Info (not a warning) - Fix ServerOptionalValidator: change to Info (not a warning) - Fix ExtensionScriptsValidator: strip file extension from script names before matching - Fix in-place buffer modification in ShellOverrideValidator (no longer uses *shellcmd = '\0')
- Use adaptive system text color in Welcome dialog for dark mode visibility - Fix "Cannot open files of this type" by implementing `application:openFiles:` - Safely route double-clicked NZB files to the background daemon via RPC
To prevent whitespace loss caused by fragmented SAX callbacks, the trimming logic is moved from the individual text handler to the element completion phase. By deferring Util::Trim() until Parse_EndElement, the logical content of an element is preserved as a single entity, ensuring that spaces between merged text and CDATA blocks are not prematurely discarded.
Connection.cpp: close and invalidate the listening socket when listen() fails to prevent descriptor leakage on bind/listen error paths. ScriptController.cpp: close the already-opened read FILE* and clear its pointer when write-pipe fdopen() fails, preventing a leaked stdio handle in the startup failure path.
Replace path-based chown() with fchown() for lock and log files to eliminate TOCTOU races between path resolution and ownership change. Open the lockfile with O_NOFOLLOW to prevent symlink redirection, and O_CLOEXEC to avoid fd leaks into child processes. Validate the opened fd with fstat/S_ISREG as defense-in-depth against non-regular files. Note: log file ownership change now occurs on first write (in Filelog) rather than eagerly at daemon startup.
Resolves issues where server speed tests would hang indefinitely due to incorrect server priority normalization and improper processing by DirectRename. - QueueCoordinator: Updated to use `NormLevel` instead of raw `Level` to correctly identify available connections. - DirectRenamer: Suppressed rename attempts for SkipDiskWrite downloads to prevent processing errors. - Diagnostics: Added pre-flight server validation for `testserverspeed` RPC-request.
- Add client-side i18n engine (i18n.js) with locale loading, language detection, and DOM translation via data-i18n attributes - Introduce locales.source.json as the source of truth for all translation keys with English text and translator descriptions - Add per-language translation files for 20 languages (webui/_locales/) - Add generate_conf_locales.py script to produce config_desc_* entries from nzbget.conf - Convert all HTML templates and JS modules to use data-i18n / translate() - Add CONTRIBUTING.md documentation for the i18n workflow
…zation race conditions (#816) - Replace hardcoded 'Filename'/'Title' with I18n.translate() calls in RSS feed dialogs - Wrap DupeMode value in I18n.translate() for translated tooltips - Fix HTML data-i18n attribute from col_name to col_title - Add col_filename and col_title translation keys - Set feed table column widths for consistent layout - Fix WebUI i18n initialization timing bug by notifying subscribers on English locale load - Add robust guards to downloads.js, history.js, status.js, and messages.js to prevent race conditions and Uncaught TypeErrors during initial page load - Fixed a bug where disk speed test buttons would "stick" to the result of a previous test (e.g., showing `DestDir` speed when opened for `InterDir`)
- UnRAR 7.22 (Windows/macOS) Support is unavailable on other platforms because RARLAB has not released the UnRAR 7.22 source code.
- fixed NewsServers TypeError - fixed overflow of labels and modal dialogs
phnzb
approved these changes
Jun 4, 2026
luckedea
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description