Remove dead code across routes, models, views, and locales#1036
Open
raulriera wants to merge 1 commit into
Open
Remove dead code across routes, models, views, and locales#1036raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
… locales Restricted reviews to %i[index new create] (show/edit/update/destroy were unimplemented), removed the unused Treatment.valid scope and Appointment#ciphered_url / #ciphered_review_url instance methods (the class method is the one used in production), deleted the unused _modal.html.erb partial, empty PracticesHelper, two unreferenced image assets, and ~20 dead i18n keys across en/es/pt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up dead code identified by an audit. Restricts
resources :reviewsto%i[index new create]since show/edit/update/destroy were unimplemented and unreachable. Removes the unusedTreatment.validscope and theAppointment#ciphered_url/#ciphered_review_urlinstance methods (the class methodciphered_review_url_for_idis the one used in production). Deletes the unused_modal.html.erbpartial, the emptyPracticesHelpermodule, and two unreferenced image assets. Prunes ~20 dead i18n keys across en/es/pt, keeping all pluralization forms and framework-referenced keys.Test plan
bin/rails testpasses (455 runs, 0 failures)