From 6796a3d8bc62cd19fe450bc41825ec1bfe80ca1f Mon Sep 17 00:00:00 2001 From: Todd Baert Date: Mon, 20 Apr 2026 16:20:31 -0400 Subject: [PATCH] fix: remove if-wrappers from error flags Signed-off-by: Todd Baert --- evaluator/flags/testkit-flags.json | 75 +++++++++----------------- flags/edge-case-flags.json | 86 +++++++++--------------------- 2 files changed, 50 insertions(+), 111 deletions(-) diff --git a/evaluator/flags/testkit-flags.json b/evaluator/flags/testkit-flags.json index 8f5e379..c2f0d60 100644 --- a/evaluator/flags/testkit-flags.json +++ b/evaluator/flags/testkit-flags.json @@ -462,38 +462,29 @@ }, "semver-invalid-version-flag": { "state": "ENABLED", - "variants": { "true": "true", "false": "false", "fallback": "fallback" }, + "variants": { "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"sem_ver": [{"var": "version"}, "=", "1.0.0"]}, - "true", "false" - ] + "sem_ver": [{"var": "version"}, "=", "1.0.0"] } }, "semver-invalid-operator-flag": { "state": "ENABLED", - "variants": { "true": "true", "false": "false", "fallback": "fallback" }, + "variants": { "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"sem_ver": [{"var": "version"}, "===", "1.0.0"]}, - "true", "false" - ] + "sem_ver": [{"var": "version"}, "===", "1.0.0"] } }, "fractional-null-bucket-key-flag": { "state": "ENABLED", - "variants": { "true": "true", "false": "false", "fallback": "fallback" }, + "variants": { "one": "one", "two": "two", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"fractional": [ - {"var": "missing_key"}, - ["one", 50], - ["two", 50] - ]}, - "true", "false" + "fractional": [ + {"var": "missing_key"}, + ["one", 50], + ["two", 50] ] } }, @@ -603,60 +594,45 @@ }, "starts-with-non-string-flag": { "state": "ENABLED", - "variants": { "true": "true", "false": "false", "fallback": "fallback" }, + "variants": { "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"starts_with": [{"var": "num"}, "abc"]}, - "true", "false" - ] + "starts_with": [{"var": "num"}, "abc"] } }, "ends-with-non-string-flag": { "state": "ENABLED", - "variants": { "true": "true", "false": "false", "fallback": "fallback" }, + "variants": { "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"ends_with": [{"var": "num"}, "xyz"]}, - "true", "false" - ] + "ends_with": [{"var": "num"}, "xyz"] } }, "starts-with-wrong-args-flag": { "state": "ENABLED", - "variants": { "true": "true", "false": "false", "fallback": "fallback" }, + "variants": { "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"starts_with": ["abc"]}, - "true", "false" - ] + "starts_with": ["abc"] } }, "ends-with-wrong-args-flag": { "state": "ENABLED", - "variants": { "true": "true", "false": "false", "fallback": "fallback" }, + "variants": { "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"ends_with": ["xyz"]}, - "true", "false" - ] + "ends_with": ["xyz"] } }, "fractional-zero-weights-flag": { "state": "ENABLED", - "variants": { "true": "true", "false": "false", "fallback": "fallback" }, + "variants": { "one": "one", "two": "two", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"fractional": [ - {"var": "targetingKey"}, - ["one", 0], - ["two", 0] - ]}, - "true", "false" + "fractional": [ + {"var": "targetingKey"}, + ["one", 0], + ["two", 0] ] } }, @@ -674,13 +650,10 @@ }, "semver-wrong-args-flag": { "state": "ENABLED", - "variants": { "true": "true", "false": "false", "fallback": "fallback" }, + "variants": { "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"sem_ver": [{"var": "version"}, "="]}, - "true", "false" - ] + "sem_ver": [{"var": "version"}, "="] } } }, diff --git a/flags/edge-case-flags.json b/flags/edge-case-flags.json index 42d6eac..15998b5 100644 --- a/flags/edge-case-flags.json +++ b/flags/edge-case-flags.json @@ -56,128 +56,98 @@ "semver-invalid-version-flag": { "state": "ENABLED", "variants": { - "true": "true", - "false": "false", + "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"sem_ver": [{"var": "version"}, "=", "1.0.0"]}, - "true", "false" - ] + "sem_ver": [{"var": "version"}, "=", "1.0.0"] } }, "semver-invalid-operator-flag": { "state": "ENABLED", "variants": { - "true": "true", - "false": "false", + "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"sem_ver": [{"var": "version"}, "===", "1.0.0"]}, - "true", "false" - ] + "sem_ver": [{"var": "version"}, "===", "1.0.0"] } }, "fractional-null-bucket-key-flag": { "state": "ENABLED", "variants": { - "true": "true", - "false": "false", + "one": "one", + "two": "two", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"fractional": [ - {"var": "missing_key"}, - ["one", 50], - ["two", 50] - ]}, - "true", "false" + "fractional": [ + {"var": "missing_key"}, + ["one", 50], + ["two", 50] ] } }, "starts-with-non-string-flag": { "state": "ENABLED", "variants": { - "true": "true", - "false": "false", + "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"starts_with": [{"var": "num"}, "abc"]}, - "true", "false" - ] + "starts_with": [{"var": "num"}, "abc"] } }, "ends-with-non-string-flag": { "state": "ENABLED", "variants": { - "true": "true", - "false": "false", + "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"ends_with": [{"var": "num"}, "xyz"]}, - "true", "false" - ] + "ends_with": [{"var": "num"}, "xyz"] } }, "starts-with-wrong-args-flag": { "state": "ENABLED", "variants": { - "true": "true", - "false": "false", + "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"starts_with": ["abc"]}, - "true", "false" - ] + "starts_with": ["abc"] } }, "ends-with-wrong-args-flag": { "state": "ENABLED", "variants": { - "true": "true", - "false": "false", + "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"ends_with": ["xyz"]}, - "true", "false" - ] + "ends_with": ["xyz"] } }, "fractional-zero-weights-flag": { "state": "ENABLED", "variants": { - "true": "true", - "false": "false", + "one": "one", + "two": "two", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"fractional": [ - {"var": "targetingKey"}, - ["one", 0], - ["two", 0] - ]}, - "true", "false" + "fractional": [ + {"var": "targetingKey"}, + ["one", 0], + ["two", 0] ] } }, @@ -196,16 +166,12 @@ "semver-wrong-args-flag": { "state": "ENABLED", "variants": { - "true": "true", - "false": "false", + "match": "match", "fallback": "fallback" }, "defaultVariant": "fallback", "targeting": { - "if": [ - {"sem_ver": [{"var": "version"}, "="]}, - "true", "false" - ] + "sem_ver": [{"var": "version"}, "="] } } }