handle unknown parameter type

Author: hauner

src/main/groovy/com/github/hauner/openapi/spring/converter/ApiConverter.groovy

@@ -131,8 +131,8 @@ class ApiConverter {
             case 'cookie':
                 return new CookieParameter (name: parameter.name, required: parameter.required, dataType: dataType)
             default:
-                // todo throw
-                null
+                // should not reach this, the openapi parser ignores parameters with unknown type.
+                throw new UnknownParameterTypeException(parameter.name, parameter.in)
         }
     }
 

src/main/groovy/com/github/hauner/openapi/spring/converter/UnknownParameterTypeException.groovy

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2019 the original authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.github.hauner.openapi.spring.converter
+
+/**
+ * thrown when the ApiConverter hits an unknown parameter type.
+ *
+ * @author Martin Hauner
+ */
+class UnknownParameterTypeException extends RuntimeException {
+
+    String name
+    String type
+
+    UnknownParameterTypeException(String name, String type) {
+        super()
+        this.name = name
+        this.type = type
+    }
+
+    @Override
+    String getMessage () {
+        "unknown parameter type: $type for parameter $name"
+    }
+
+}

src/test/groovy/com/github/hauner/openapi/spring/converter/ApiConverterParameterSpec.groovy

@@ -16,6 +16,7 @@
 
 package com.github.hauner.openapi.spring.converter
 
+import spock.lang.Ignore
 import spock.lang.Specification
 
 import static com.github.hauner.openapi.spring.support.OpenApiParser.parse
@@ -182,4 +183,38 @@ paths:
         param.annotationWithPackage == 'org.springframework.web.bind.annotation.CookieValue'
     }
 
+    @Ignore("the openapi parser ignores parameters with unknown types")
+    void "throws on unknown parameter"() {
+        def openApi = parse (
+"""\
+openapi: 3.0.2
+info:
+  title: test unknown parameter type
+  version: 1.0.0
+
+paths:
+  /endpoint:
+
+    get:
+      tags:
+        - endpoint
+      parameters:
+        - name: foo
+          description: unknown, required, string
+          in: unknown
+          schema:
+            type: string
+      responses:
+        '204':
+          description: empty
+""")
+
+        when:
+        new ApiConverter ().convert (openApi)
+
+        then:
+        def e = thrown (UnknownParameterTypeException)
+        e.name == 'foo'
+        e.type == 'unknown'
+    }
 }