[DEPR]: Remove Enterprise Catalog API V1 from edx-enterprise

[feanil]

We are in the process of building a new service that will replace the existing enterprise catalog functionality, so we plan to deprecate and remove the existing endpoints at the point when we have the new ones up and running.

We will remove these endpoints specifically:

• EnterpriseCustomerViewSet::contains_content_items (https://github.com/edx/edx-enterprise/blob/master/enterprise/api/v1/views.py#L142)
• All of EnterpriseCustomerCatalogViewSet except for:
  ** course_detail: https://github.com/edx/edx-enterprise/blob/master/enterprise/api/v1/views.py#L350
  ** course_run_detail: https://github.com/edx/edx-enterprise/blob/master/enterprise/api/v1/views.py#L378
  ** program_detail: https://github.com/edx/edx-enterprise/blob/master/enterprise/api/v1/views.py#L406
  See here for more details on the migration plan: https://docs.google.com/document/d/1jvmryjFR6KwLdHKbJYpNRwtvW26-gJTBhkPeD2AufEY/edit

Additional Info

Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-61

[dianakhuang]

The replacement service for these v1 apis is: https://github.com/openedx/enterprise-catalog

[dianakhuang]

After talking to Enterprise folks here at 2U, we have determined that we have three usages that are still pointing to the old catalog endpoints, but there's only one relevant one that should be implementable on the new enterprise-catalog service.

Usages:

• ecommerce usage 1 ecommerce usage 2
• frontend-app-admin-portal usage
• enterprise-data usage

Recommended course of action:

• I do not believe we should remove the EnterpriseCustomer endpoint as part of this work, as even enterprise-catalog makes calls to it right now.
• We should create an endpoint in the enterprise-catalog which returns the data that these usages need or verify that the existing ones cover these usages. We believe the only missing one is that returns catalog ids that match the customer ids.
• We can then replace these usages with corresponding calls to the enterprise-catalog service.
• Then we can remove the enterprise_catalogs endpoint.

[ruzniaievdm]

@dianakhuang I made an additional research and determined that this endpoint already exists in enterprise-catalogs and some of methods exists in endpoint above.

As for other methods, like course_detail, course_run_detail, program_detail the calls these methods in edx-enterprise is no longer used. Instead ecommerce, frontend-app-admin-portal, edx-enterprise-data repositories called to enterprise-catalog or discovery api.
Generalizations of these methods already exist in enterprise-catalog, but in a different endpoint and serializer looks like this.
If this is indeed the case, then I completely remove this endpoint without moving this methods.

And one more question.
The response in ecommerce is different from enterprise-catalog. Missed pagination fields like num_pages, current_page, start .
Does it make sense to add the pagination fields above in the response of enterpise-catalog?

[feanil]

@ruzniaievdm trying to summarize to make sure I've understood currectly. It sounds like you're saying the endpoint we need to create already exists in the enterprise catalog. We just need to start using it and then we can remove the version that's in the edx-enterprise repo?

[ruzniaievdm]

@feanil Yes, after my research, I came to the conclusion that this is true.
Just wanted to get approval from you