Description
Current behavior:
tallies.out and tally DataFrames for a MeshSurfaceFilter always label the mesh cell edges as "Outgoing, x-min", "Incoming, x-min ", ..., "Incoming, z-max". These labels are used for all mesh types. See filter_meshsurface.cpp#L36
Desired solution:
When the mesh is a CylindricalMesh, use r instead of x and phi instead of y. When the mesh is a SphericalMesh, use r, phi, and theta instead of x, y, and z. Retain the existing labels for the other three varieties of mesh.
Alternatives
Allow the user to assign custom labels to a mesh's three dimensions This opens the door to accidental mislabeling.1
Compatibility
This would change existing interfaces to tally files that rely on x-min, ..., z-max labeling.
Description
Current behavior:
tallies.out and tally DataFrames for a
MeshSurfaceFilteralways label the mesh cell edges as "Outgoing, x-min", "Incoming, x-min ", ..., "Incoming, z-max". These labels are used for all mesh types. See filter_meshsurface.cpp#L36Desired solution:
When the mesh is a
CylindricalMesh, use r instead of x and phi instead of y. When the mesh is aSphericalMesh, use r, phi, and theta instead of x, y, and z. Retain the existing labels for the other three varieties of mesh.Alternatives
Allow the user to assign custom labels to a mesh's three dimensions This opens the door to accidental mislabeling.1
Compatibility
This would change existing interfaces to tally files that rely on x-min, ..., z-max labeling.
Footnotes
a real possibility at least for cylindrical meshes, where OpenMC uses (r, phi, z) and MCNP uses (r, z, theta). ↩