fixes with publish/delete

Author: geetu040

openml/_api/resources/base/versions.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from collections.abc import Mapping
-from typing import Any
+from typing import Any, cast
 
 import xmltodict
 
@@ -76,7 +76,7 @@ def untag(self, resource_id: int, tag: str) -> list[str]:
     def _get_endpoint_name(self) -> str:
         if self.resource_type == ResourceType.DATASET:
             return "data"
-        return self.resource_type.name
+        return cast("str", self.resource_type.value)
 
     def _handle_delete_exception(
         self, resource_type: str, exception: OpenMLServerException
@@ -114,23 +114,23 @@ def _handle_delete_exception(
         raise exception
 
     def _extract_id_from_upload(self, parsed: Mapping[str, Any]) -> int:
-        # reads id from
-        # sample parsed dict: {"oml:openml": {"oml:upload_flow": {"oml:id": "42"}}}
+        # reads id from upload response
+        # actual parsed dict: {"oml:upload_flow": {"@xmlns:oml": "...", "oml:id": "42"}}
 
         # xmltodict always gives exactly one root key
         ((_, root_value),) = parsed.items()
 
         if not isinstance(root_value, Mapping):
             raise ValueError("Unexpected XML structure")
 
-        # upload node (e.g. oml:upload_task, oml:study_upload, ...)
-        ((_, upload_value),) = root_value.items()
+        # Look for oml:id directly in the root value
+        if "oml:id" in root_value:
+            id_value = root_value["oml:id"]
+            if isinstance(id_value, (str, int)):
+                return int(id_value)
 
-        if not isinstance(upload_value, Mapping):
-            raise ValueError("Unexpected upload node structure")
-
-        # ID is the only leaf value
-        for v in upload_value.values():
+        # Fallback: check all values for numeric/string IDs
+        for v in root_value.values():
             if isinstance(v, (str, int)):
                 return int(v)
 

tests/test_api/test_http.py

@@ -149,10 +149,5 @@ def test_post_and_delete(self):
         finally:
             # DELETE the task if it was created
             if task_id is not None:
-                try:
-                    del_response = self.http_client.delete(f"task/{task_id}")
-                    # optional: verify delete
-                    if del_response.status_code != 200:
-                        print(f"Warning: delete failed for task {task_id}")
-                except Exception as e:
-                    print(f"Warning: failed to delete task {task_id}: {e}")
+                del_response = self.http_client.delete(f"task/{task_id}")
+                self.assertEqual(del_response.status_code, 200)

tests/test_api/test_versions.py

@@ -0,0 +1,44 @@
+import pytest
+from openml.testing import TestAPIBase
+from openml._api.resources.base.versions import ResourceV1
+from openml._api.resources.base.resources import ResourceType
+
+
+class TestResourceV1(TestAPIBase):
+    def setUp(self):
+        super().setUp()
+        self.resource = ResourceV1(self.http_client)
+        self.resource.resource_type = ResourceType.TASK
+
+    @pytest.mark.uses_test_server()
+    def test_publish_and_delete(self):
+        task_xml = """
+        <oml:task_inputs xmlns:oml="http://openml.org/openml">
+            <oml:task_type_id>5</oml:task_type_id>
+            <oml:input name="source_data">193</oml:input>
+            <oml:input name="estimation_procedure">17</oml:input>
+        </oml:task_inputs>
+        """
+
+        task_id = None
+        try:
+            # Publish the task
+            task_id = self.resource.publish(
+                "task",
+                files={"description": task_xml},
+            )
+
+            # Get the task to verify it exists
+            get_response = self.http_client.get(f"task/{task_id}")
+            self.assertEqual(get_response.status_code, 200)
+
+        finally:
+            # delete the task if it was created
+            if task_id is not None:
+                success = self.resource.delete(task_id)
+                self.assertTrue(success)
+
+
+    @pytest.mark.uses_test_server()
+    def test_tag_and_untag(self):
+        pass