added tests

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>

Author: Omswastik-11

openml/_api/clients/http.py

@@ -151,9 +151,14 @@ def _parse_exception_response(
         if "json" in content_type:
             server_exception = response.json()
             server_error = server_exception["detail"]
-            code = server_error.get("code")
-            message = server_error.get("message")
-            additional_information = server_error.get("additional_information")
+            if isinstance(server_error, dict):
+                code = server_error.get("code")
+                message = server_error.get("message")
+                additional_information = server_error.get("additional_information")
+            else:
+                code = None
+                message = str(server_error)
+                additional_information = None
         else:
             server_exception = xmltodict.parse(response.text)
             server_error = server_exception["oml:error"]

openml/_api/resources/base/resources.py

@@ -54,7 +54,7 @@ def list(
     ) -> pd.DataFrame: ...
 
     @abstractmethod
-    def create(self, flow: OpenMLFlow) -> OpenMLFlow | tuple[OpenMLFlow, Response]: ...
+    def publish(self, flow: OpenMLFlow) -> OpenMLFlow | tuple[OpenMLFlow, Response]: ...  # type: ignore[override]
 
     @abstractmethod
     def delete(self, flow_id: int) -> bool: ...

openml/_api/resources/flows.py

@@ -3,11 +3,10 @@
 from typing import Any
 
 import pandas as pd
-import requests
 import xmltodict
 
 from openml._api.resources.base import FlowsAPI
-from openml.exceptions import OpenMLServerException
+from openml.exceptions import OpenMLServerError, OpenMLServerException
 from openml.flows.flow import OpenMLFlow
 
 
@@ -55,17 +54,7 @@ def exists(self, name: str, external_version: str) -> int | bool:
             raise ValueError("Argument 'version' should be a non-empty string")
 
         data = {"name": name, "external_version": external_version, "api_key": self._http.api_key}
-        # Avoid duplicating base_url when server already contains the API path
-        server = self._http.server
-        base = self._http.base_url
-        if base and base.strip("/") in server:
-            url = server.rstrip("/") + "/flow/exists"
-            response = requests.post(
-                url, data=data, headers=self._http.headers, timeout=self._http.timeout
-            )
-            xml_response = response.text
-        else:
-            xml_response = self._http.post("flow/exists", data=data).text
+        xml_response = self._http.post("flow/exists", data=data).text
         result_dict = xmltodict.parse(xml_response)
         # Detect error payloads and raise
         if "oml:error" in result_dict:
@@ -116,20 +105,8 @@ def list(
         if uploader is not None:
             api_call += f"/uploader/{uploader}"
 
-        server = self._http.server
-        base = self._http.base_url
-        if base and base.strip("/") in server:
-            url = server.rstrip("/") + "/" + api_call
-            response = requests.get(
-                url,
-                headers=self._http.headers,
-                params={"api_key": self._http.api_key},
-                timeout=self._http.timeout,
-            )
-            xml_string = response.text
-        else:
-            response = self._http.get(api_call, use_api_key=True)
-            xml_string = response.text
+        response = self._http.get(api_call, use_api_key=True)
+        xml_string = response.text
         flows_dict = xmltodict.parse(xml_string, force_list=("oml:flow",))
 
         if "oml:error" in flows_dict:
@@ -158,7 +135,7 @@ def list(
 
         return pd.DataFrame.from_dict(flows, orient="index")
 
-    def create(self, flow: OpenMLFlow) -> OpenMLFlow:
+    def publish(self, flow: OpenMLFlow) -> OpenMLFlow:  # type: ignore[override]
         """Create a new flow on the OpenML server.
 
         under development , not fully functional yet
@@ -187,16 +164,7 @@ def create(self, flow: OpenMLFlow) -> OpenMLFlow:
         # POST to server (multipart/files). Ensure api_key is sent in the form data.
         files = file_elements
         data = {"api_key": self._http.api_key}
-        # If server already contains base path, post directly with requests to avoid double base_url
-        server = self._http.server
-        base = self._http.base_url
-        if base and base.strip("/") in server:
-            url = server.rstrip("/") + "/flow"
-            response = requests.post(
-                url, files=files, data=data, headers=self._http.headers, timeout=self._http.timeout
-            )
-        else:
-            response = self._http.post("flow", files=files, data=data)
+        response = self._http.post("flow", files=files, data=data)
 
         parsed = xmltodict.parse(response.text)
         if "oml:error" in parsed:
@@ -222,9 +190,6 @@ def delete(self, flow_id: int) -> bool:
         self._http.delete(f"flow/{flow_id}")
         return True
 
-    def publish(self) -> None:
-        pass
-
 
 class FlowsV2(FlowsAPI):
     def get(
@@ -277,8 +242,8 @@ def exists(self, name: str, external_version: str) -> int | bool:
             result = response.json()
             flow_id: int | bool = result.get("flow_id", False)
             return flow_id
-        except (requests.exceptions.HTTPError, KeyError):
-            # v2 returns 404 when flow doesn't exist
+        except (OpenMLServerError, KeyError):
+            # v2 returns 404 when flow doesn't exist, which raises OpenMLServerError
             return False
 
     def list(
@@ -291,15 +256,12 @@ def list(
     ) -> pd.DataFrame:
         raise NotImplementedError("flows (list) not yet implemented in v2 server")
 
-    def create(self, flow: OpenMLFlow) -> OpenMLFlow:
+    def publish(self, flow: OpenMLFlow) -> OpenMLFlow:  # type: ignore[override]
         raise NotImplementedError("POST /flows (create) not yet implemented in v2 server")
 
     def delete(self, flow_id: int) -> bool:
         raise NotImplementedError("DELETE /flows/{id} not yet implemented in v2 server")
 
-    def publish(self) -> None:
-        raise NotImplementedError("publish not implemented in v2 server")
-
     @staticmethod
     def _convert_v2_to_v1_format(v2_json: dict[str, Any]) -> dict[str, dict]:
         """Convert v2 JSON response to v1 XML-dict format for OpenMLFlow._from_dict().

openml/base.py

@@ -128,15 +128,15 @@ def publish(self) -> OpenMLBase:
         """Publish the object on the OpenML server."""
         from openml._api import api_context
 
-        # 1. Resolve the correct resource manager (e.g., Flows, Runs)
         resource_manager = api_context.backend.get_resource_for_entity(self)
 
-        # 2. Delegate creation to the backend (Handles V1/V2 switching internally)
-        # The backend returns the updated entity (with ID) or the ID itself.
-        published_entity = resource_manager.create(self)  # type: ignore
+        published_entity = resource_manager.publish(self)  # type: ignore
 
-        # 3. Update self with ID if not already done (V2 response handling)
-        if self.id is None and published_entity.id is not None:
+        if (
+            published_entity is not None
+            and hasattr(published_entity, "id")
+            and published_entity.id is not None
+        ):
             self.id = published_entity.id  # type: ignore
 
         return self

openml/flows/functions.py

@@ -69,7 +69,7 @@ def _get_cached_flow(fid: int) -> OpenMLFlow:
         raise OpenMLCacheException(f"Flow file for fid {fid} not cached") from e
 
 
-@openml.utils.thread_safe_if_oslo_installed
+# @openml.utils.thread_safe_if_oslo_installed
 def get_flow(flow_id: int, reinstantiate: bool = False, strict_version: bool = True) -> OpenMLFlow:  # noqa: FBT002
     """Download the OpenML flow for a given flow ID.
 
@@ -192,7 +192,7 @@ def flow_exists(name: str, external_version: str) -> int | bool:
     """
     if not (isinstance(name, str) and len(name) > 0):
         raise ValueError("Argument 'name' should be a non-empty string")
-    if not (isinstance(name, str) and len(external_version) > 0):
+    if not (isinstance(external_version, str) and len(external_version) > 0):
         raise ValueError("Argument 'version' should be a non-empty string")
 
     from openml._api import api_context