Skip to content

Commit 8802b8a

Browse files
committed
correct the tests
1 parent aa9d486 commit 8802b8a

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

tests/test_api/test_flow.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ def test_exists_nonexistent(self):
5454

5555
def test_list(self):
5656
"""Test listing flows from the V1 API."""
57-
flows_df = self.resource.list(limit=10)
57+
limit = 10
58+
flows_df = self.resource.list(limit=limit)
5859

59-
self.assertGreater(len(flows_df), 0)
60-
self.assertLessEqual(len(flows_df), 10)
60+
self.assertEqual(len(flows_df), limit)
6161
self.assertIn("id", flows_df.columns)
6262
self.assertIn("name", flows_df.columns)
6363
self.assertIn("version", flows_df.columns)
@@ -67,16 +67,18 @@ def test_list(self):
6767

6868
def test_list_with_offset(self):
6969
"""Test listing flows with offset from the V1 API."""
70-
flows_df = self.resource.list(limit=5, offset=10)
70+
limit = 5
71+
flows_df = self.resource.list(limit=limit, offset=10)
7172

72-
self.assertGreater(len(flows_df), 0)
73-
self.assertLessEqual(len(flows_df), 5)
73+
self.assertEqual(len(flows_df), limit)
7474

7575
def test_list_with_tag_limit_offset(self):
7676
"""Test listing flows with filters from the V1 API."""
77-
flows_df = self.resource.list(tag="weka", limit=5, offset=0, uploader=16)
77+
limit = 5
78+
flows_df = self.resource.list(tag="weka", limit=limit, offset=0, uploader=16)
7879

7980
self.assertTrue(hasattr(flows_df, "columns"))
81+
self.assertLessEqual(len(flows_df), limit)
8082
if len(flows_df) > 0:
8183
self.assertIn("id", flows_df.columns)
8284

tests/test_flows/test_flow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ def test_semi_legal_flow(self):
301301

302302
@pytest.mark.sklearn()
303303
@mock.patch("openml.flows.functions.get_flow")
304-
@mock.patch("openml._api.clients.http.HTTPClient.post")
304+
@mock.patch("openml._api_calls._perform_api_call")
305305
@mock.patch("openml.flows.functions.flow_exists")
306306
def test_publish_error(self, api_call_mock, flow_exists_mock, get_flow_mock):
307307
model = sklearn.ensemble.RandomForestClassifier()

0 commit comments

Comments
 (0)