Loading recipes fails on Java 24 due to ClassGraph's "`enableMemoryMapping()` is not supported on Java 24+"

[Jiehong]

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project.

<plugin>
        <groupId>org.openrewrite.maven</groupId>
        <artifactId>rewrite-maven-plugin</artifactId>
        <version>6.12.0</version>
        <configuration>
          <activeRecipes>
            <recipe>org.openrewrite.staticanalysis.NeedBraces</recipe>
          </activeRecipes>
        </configuration>
</plugin>

Does not matter which recipe.

What is the smallest, simplest way to reproduce the problem?

What did you expect to see?

No error message

What did you see instead?

Execution of goal org.openrewrite.maven:rewrite-maven-plugin:6.12.0:dryRun failed: enableMemoryMapping() is not supported on Java 24+

What is the full stack trace of any errors you encountered?

Caused by: org.apache.maven.plugin.PluginExecutionException: Execution apply of goal org.openrewrite.maven:rewrite-maven-plugin:6.12.0:dryRun failed: enableMemoryMapping() is not supported on Java 24+
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject (SmartBuilderImpl.java:206)
    at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run (SmartBuilderImpl.java:71)
    at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:545)
    at java.util.concurrent.FutureTask.run (FutureTask.java:328)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1095)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:619)
    at java.lang.Thread.run (Thread.java:1447)
Caused by: java.lang.IllegalArgumentException: enableMemoryMapping() is not supported on Java 24+
    at io.github.classgraph.ClassGraph.enableMemoryMapping (ClassGraph.java:1433)
    at org.openrewrite.config.ClasspathScanningLoader.scanYaml (ClasspathScanningLoader.java:128)
    at org.openrewrite.config.ClasspathScanningLoader.lambda$new$0 (ClasspathScanningLoader.java:64)
    at org.openrewrite.config.ClasspathScanningLoader.ensureScanned (ClasspathScanningLoader.java:222)
    at org.openrewrite.config.ClasspathScanningLoader.loadRecipe (ClasspathScanningLoader.java:210)
    at org.openrewrite.config.Environment.loadRecipe (Environment.java:210)
    at org.openrewrite.config.Environment.activateRecipes (Environment.java:162)
    at org.openrewrite.maven.AbstractRewriteBaseRunMojo.listResults (AbstractRewriteBaseRunMojo.java:125)
    at org.openrewrite.maven.AbstractRewriteDryRunMojo.execute (AbstractRewriteDryRunMojo.java:74)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject (SmartBuilderImpl.java:206)
    at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run (SmartBuilderImpl.java:71)
    at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:545)
    at java.util.concurrent.FutureTask.run (FutureTask.java:328)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1095)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:619)
    at java.lang.Thread.run (Thread.java:1447)

[timtebeek]

hi! Thanks for the report; that seems to be a very recent addition turned up by yesterday's release:

• nonapi.io.github.classgraph.utils.FileUtils invokes terminally deprecated method sun.misc.Unsafe::invokeCleaner classgraph/classgraph#899

I guess we could pin back to a version that works with Java 24 still, or not call that particular method anymore.

[protocol7]

We're also running into this. How about something like this? I don't know what impact this may have on performance though.

diff --git a/rewrite-core/src/main/java/org/openrewrite/config/ClasspathScanningLoader.java b/rewrite-core/src/main/java/org/openrewrite/config/ClasspathScanningLoader.java
index 4f4881504..42399e35f 100644
--- a/rewrite-core/src/main/java/org/openrewrite/config/ClasspathScanningLoader.java
+++ b/rewrite-core/src/main/java/org/openrewrite/config/ClasspathScanningLoader.java
@@ -125,7 +125,7 @@ private ClasspathScanningLoader() {
      * non-declarative recipes they depend on that would be discovered by scanClasses
      */
     private void scanYaml(ClassGraph classGraph, Properties properties, Collection<? extends ResourceLoader> dependencyResourceLoaders, @Nullable ClassLoader classLoader) {
-        try (ScanResult scanResult = classGraph.enableMemoryMapping().scan()) {
+        try (ScanResult scanResult = classGraph.scan()) {
             List<YamlResourceLoader> yamlResourceLoaders = new ArrayList<>();

             scanResult.getResourcesWithExtension("yml").forEachInputStreamIgnoringIOException((res, input) ->

[timtebeek]

I believe @knutwannheden has most recently looked at recipe loading performance; anything you can share here?

Indeed could make sense in the short term to pin back, and in the slightly longer term take out (or conditionally call) that method.

[knutwannheden]

I am also unsure about the effect of that enableMemoryMapping() call, but I think it is probably safe to remove it.